Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test user assignment to maps tests - 2 #75890

Merged
merged 10 commits into from
Aug 27, 2020
Merged

Test user assignment to maps tests - 2 #75890

merged 10 commits into from
Aug 27, 2020

Conversation

bhavyarm
Copy link
Contributor

Adding test user to maps tests so we can run them with minimum required permissions and not super user

Part of the meta issue here - #60815

@bhavyarm bhavyarm requested review from wylieconlon and removed request for wylieconlon August 25, 2020 15:41
@bhavyarm bhavyarm self-assigned this Aug 25, 2020
@bhavyarm bhavyarm added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:QA Team label for QA Team labels Aug 25, 2020
@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm bhavyarm marked this pull request as ready for review August 25, 2020 20:40
@bhavyarm bhavyarm requested a review from a team as a code owner August 25, 2020 20:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

LeeDr
LeeDr approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I only code reviewed.

thomasneirynck
thomasneirynck approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm code review.

x-pack/test/functional/apps/maps/full_screen_mode.js

describe('maps full screen mode', () => {
before(async () => {
await esArchiver.loadIfNeeded('maps/data');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 for cleaning up this cruft!

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor

code reviewed only. LGTM

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm bhavyarm merged commit d556c79 into elastic:master Aug 27, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 75890 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 31, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 75890 or prevent reminders by adding the backport:skip label.

@bhavyarm bhavyarm mentioned this pull request Sep 2, 2020
Merged
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Sep 2, 2020
@bhavyarm
Test user assignment to maps tests - 2 (elastic#75890)
3365422 
and removing unused data from fullscreen maps.js
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 2, 2020
bhavyarm added a commit that referenced this pull request Sep 2, 2020
@bhavyarm
Test user assignment to maps tests - 2 (#75890) (#76535)
c9c30e3
@LeeDr LeeDr added the v7.10.0 label Sep 2, 2020
@bhavyarm bhavyarm mentioned this pull request Feb 5, 2021
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@LeeDr LeeDr LeeDr approved these changes

@rashmivkulkarni rashmivkulkarni Awaiting requested review from rashmivkulkarni

Assignees

@bhavyarm bhavyarm

Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team test_xpack_functional v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bhavyarm @elasticmachine @rashmivkulkarni @kibanamachine @thomasneirynck @LeeDr