Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Add reusable FlashMessages helper #75901

Merged
merged 10 commits into from
Aug 27, 2020
Merged

[Enterprise Search] Add reusable FlashMessages helper #75901

merged 10 commits into from
Aug 27, 2020

Commits on Aug 26, 2020

  1. Set up basic shared FlashMessages & FlashMessagesLogic

    @cee-chen
    cee-chen committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    03fee53 View commit details
    Browse the repository at this point in the history

  2. Add top-level FlashMessagesProvider and history listener 

    - This ensures that:
  - Our FlashMessagesLogic is a global state that persists throughout the entire app and only unmounts when the app itself does (allowing for persistent messages if needed)
  - history.listen enables the same behavior as previously, where flash messages would be cleared between page views
    @cee-chen
    cee-chen committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    0d8215c View commit details
    Browse the repository at this point in the history

  3. Set up queued messages that appear on page nav/load

    @cee-chen
    cee-chen committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    d83d23a View commit details
    Browse the repository at this point in the history

  4. [AS] Add FlashMessages component to Engines Overview 

    + add Kea/Redux context/state to mountWithContext (in order for tests to pass)
    @cee-chen
    cee-chen committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    d9eeb2a View commit details
    Browse the repository at this point in the history

  5. Fix missing type exports, replace previous IFlashMessagesProps

    @cee-chen
    cee-chen committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    5dc0a24 View commit details
    Browse the repository at this point in the history

  6. [WS] Remove flashMessages state in OverviewLogic 

    - in favor of either connecting it or using FlashMessagesLogic directly in the future
    @cee-chen
    cee-chen committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    4150a84 View commit details
    Browse the repository at this point in the history

  7. PR feedback: DRY out EUI callout color type def

    @cee-chen
    cee-chen committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    28275c1 View commit details
    Browse the repository at this point in the history

  8. PR Feedback: make flashMessages method names more explicit

    @cee-chen
    cee-chen committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    ec50b60 View commit details
    Browse the repository at this point in the history

  9. PR Feedback: Shorter FlashMessagesLogic type names

    @cee-chen
    cee-chen committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    adc814e View commit details
    Browse the repository at this point in the history

  10. PR feedback: Typing 

    Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>
    @byronhulcher
    Constance and byronhulcher committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    6481a01 View commit details
    Browse the repository at this point in the history