Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using test_user with minimum privileges for canvas functional ui tests #75917

Merged
merged 8 commits into from
Aug 27, 2020

Conversation

rashmivkulkarni
Copy link
Contributor

Meta issue: #60815

Summary
This PR replaces elastic superuser with test_user with minimum privileges assigned to the test_user.

New role created: global_canvas_read
Checklist

  • Unit or functional tests were updated or added to match the most common scenarios

@rashmivkulkarni rashmivkulkarni added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas test_xpack_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 25, 2020
@rashmivkulkarni rashmivkulkarni requested a review from a team as a code owner August 25, 2020 20:09
@rashmivkulkarni rashmivkulkarni self-assigned this Aug 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only code reviewed.

Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ran them in my local

Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rashmivkulkarni rashmivkulkarni merged commit c08bf7f into elastic:master Aug 27, 2020
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Aug 27, 2020
elastic#75917)

* incorporating test_user wth specific roles for the canvas functional ui tests

* additional checks - removed comments

* changes to incorporate code comments

* lint check

* incorporate code reviews

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rashmivkulkarni added a commit that referenced this pull request Aug 27, 2020
#75917) (#76056)

* incorporating test_user wth specific roles for the canvas functional ui tests

* additional checks - removed comments

* changes to incorporate code comments

* lint check

* incorporate code reviews

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas test_xpack_functional v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants