Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Pipelines] Add descriptions for ingest processors A-D #75975

Merged
merged 24 commits into from
Sep 4, 2020
Merged

[Ingest Pipelines] Add descriptions for ingest processors A-D #75975

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
5a74358
Fixing formatting issues identified by Prettier, part 2.
Aug 26, 2020
377a778
Fixing helpText labels.
Aug 26, 2020
c233ecf
Adding {value} object for dissect processor.
Aug 26, 2020
446c108
Incorporating reviewer feedback.
Aug 27, 2020
a848afe
fix dropdown not rendering
alisonelizabeth Aug 27, 2020
404ebb4
Fixing typo.
Aug 27, 2020
adf6e80
Merge branch 'master' into docs__update-ingest-pipeline-strings
elasticmachine Aug 27, 2020
8e34f7a
add support for FormattedMessage in help text
alisonelizabeth Aug 27, 2020
439dfdb
fix TS
alisonelizabeth Aug 29, 2020
6de3d1e
Merge branch 'master' into docs__update-ingest-pipeline-strings
elasticmachine Aug 31, 2020
2835d3d
Updating some strings and trying to add code formatting.
Aug 31, 2020
f4fdf28
fix formatted message
alisonelizabeth Aug 31, 2020
a0be7d0
Editing some field descriptions.
Aug 31, 2020
929e016
Apply suggestions from code review
Sep 1, 2020
67e3f5f
Trying to add EuiLink, plus edits.
Sep 1, 2020
9145874
fix help text for dissect processor
alisonelizabeth Sep 1, 2020
dfc4b4f
Incorporating reviewer feedback.
Sep 1, 2020
e129444
Merge branch 'master' into docs__update-ingest-pipeline-strings
elasticmachine Sep 2, 2020
b588bd9
Trying to add another EUI element, plus edits.
Sep 2, 2020
6b43188
fix date_index_name description text
alisonelizabeth Sep 2, 2020
0a1b715
Minor edit.
Sep 2, 2020
9982b01
Fixing linter error.
Sep 2, 2020
500403b
Merge branch 'master' into docs__update-ingest-pipeline-strings
Sep 4, 2020
6872e49
Removing FunctionComponent, which was not read and caused build errors.
Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...onents/pipeline_processors_editor/components/manage_processor_form/processors/dissect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

import React, { FunctionComponent } from 'react';
import { EuiCode, EuiLink, EuiText } from '@elastic/eui';
import { EuiCode, EuiLink } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n/react';
import { TextEditor } from '../field_components';
Expand Down
19 changes: 13 additions & 6 deletions ...on/components/pipeline_processors_editor/components/shared/map_processor_type_to_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
*/

import { i18n } from '@kbn/i18n';
import { FunctionComponent, ReactNode } from 'react';
import { React, FunctionComponent, ReactNode } from 'react';
import { FormattedMessage } from '@kbn/i18n/react';
import { EuiCode } from '@elastic/eui';

import {
Append,
Expand Down Expand Up @@ -86,7 +88,7 @@ export const mapProcessorTypeToDescriptor: MapProcessorTypeToDescriptor = {
}),
description: i18n.translate('xpack.ingestPipelines.processors.description.convert', {
defaultMessage:
'Converts a field in the currently ingested document to a different type, such as converting a string to an integer.',
'Converts a field to a different data type. For example, you can convert a string to an long.',
}),
},
csv: {
Expand Down Expand Up @@ -115,10 +117,15 @@ export const mapProcessorTypeToDescriptor: MapProcessorTypeToDescriptor = {
label: i18n.translate('xpack.ingestPipelines.processors.label.dateIndexName', {
defaultMessage: 'Date index name',
}),
description: i18n.translate('xpack.ingestPipelines.processors.description.dateIndexName', {
defaultMessage:
'Uses a date or timestamp to add documents to the correct time-based index. Index names must use a date math pattern, such as my-index-yyyy-MM-dd.',
}),
description: {
defaultMessage: (
<FormattedMessage
id="xpack.ingestPipelines.processors.description.dateIndexName"
defaultMessage="Uses a date or timestamp to add documents to the correct time-based index. Index names must use a date math pattern, such as {value}."
values={{ value: <EuiCode inline>{'my-index-yyyy-MM-dd'}</EuiCode> }}
/>
),
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to remove the { defaultMessage: ... } wrapping the <FormattedMessage ... /> component - you you will probably also get a TS error about this :)

},
dissect: {
FieldsComponent: Dissect,
Expand Down