[APM] Prevent imports of public in server code #75979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
cauemarcondes
added
release_note:skip
cauemarcondes
commented
Aug 26, 2020
| @@ -4,11 +4,12 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
| import { HttpSetup } from 'kibana/public'; | |||
| import { callApi, FetchOptions } from './callApi'; | |||
| import { FetchOptions } from '../../../common/fetch_options'; | |||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | |||
| import { APMAPI } from '../../../server/routes/create_apm_api'; | |||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | |||
There was a problem hiding this comment.
@elastic/apm-ui We still have a lot of this to remove from the public directory, it might take some time to fix all since most of them are types which is automatically inferred.
|
Thanks so much for this! Mind also removing the exception to the no-restricted-paths rule in eslint as part of this PR? https://github.com/elastic/kibana/blob/master/.eslintrc.js#L301 |
|
@elasticmachine merge upstream |
cauemarcondes
force-pushed
the
apm-fix-imports
branch
from
68427e9
to
ac50299
Compare
💚 Build SucceededBuild metricsdistributable file count
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 31, 2020
…s-for-710 * 'master' of github.com:elastic/kibana: (43 commits) [APM] Chart units don't update when toggling the chart legends (elastic#74931) [ILM] Add support for frozen phase in UI (elastic#75968) Hides advanced json for count metric (elastic#74636) add client-side feature usage API (elastic#75486) [Maps] add drilldown support map embeddable (elastic#75598) [Enterprise Search] Request handler refactors/enhancements + update existing routes to use shared handler (elastic#76106) [Resolver] model `location.search` in redux (elastic#76140) [APM] Prevent imports of public in server code (elastic#75979) fix eslint issue skip flaky suite (elastic#76223) [APM] Transaction duration anomaly alerting integration (elastic#75719) [Transforms] Avoid using "Are you sure" (elastic#75932) [Security Solution][Exceptions] - Fix bug of alerts not updating after closure from exceptions modal (elastic#76145) [plugin-helpers] improve 3rd party KP plugin support (elastic#75019) [docs/getting-started] link to yarn v1 specifically (elastic#76169) [Security_Solution][Resolver] Resolver loading and error state (elastic#75600) Fixes App Search documentation links (elastic#76133) Fix alerts unable to create / update when the name has trailing whitepace(s) (elastic#76079) [Resolver] Fix useSelector usage (elastic#76129) [Enterprise Search] Migrate util and components from ent-search (elastic#76051) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/data_tier_allocation/node_allocation.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/services/policies/types.ts # x-pack/plugins/index_lifecycle_management/public/application/services/policies/warm_phase.ts
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Aug 31, 2020
* renaming test file * removing eslint rule * restructuring observability types * refactoring fetchOptions type
cauemarcondes
added a commit
that referenced
this pull request
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #67210