[Ingest Pipelines] Add descriptions for ingest processors E-J #76113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
added
Feature:Ingest Node Pipelines
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
jrodewig
changed the title
4 tasks
jrodewig
changed the title
|
Switching back to draft. I'll update once #75975 is merged. |
jrodewig
commented
Sep 3, 2020
...ation/components/pipeline_processors_editor/components/shared/map_processor_type_to_form.tsx
Outdated
Show resolved
Hide resolved
jloleysens
requested changes
Sep 4, 2020
There was a problem hiding this comment.
Hi @jrodewig thanks for making these changes! We are looking in good shape - I've recommended a pattern for getting esDocUrl in the context of processor descriptions.
...ation/components/pipeline_processors_editor/components/shared/map_processor_type_to_form.tsx
Outdated
Show resolved
Hide resolved
...ation/components/pipeline_processors_editor/components/shared/map_processor_type_to_form.tsx
Show resolved
Hide resolved
…pipeline_processors_editor/components/shared/map_processor_type_to_form.tsx Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
jloleysens
approved these changes
Sep 4, 2020
|
Thanks @jloleysens! |
lockewritesdocs
approved these changes
Sep 4, 2020
There was a problem hiding this comment.
Built locally and looks great! I'm 👍 on these changes. Thanks @jrodewig.
|
Thanks @lockewritesdocs! |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
jrodewig
added a commit
that referenced
this pull request
Sep 8, 2020
…76113) (#76948) * [Ingest Pipelines] Add descriptions for ingest processors E-J (#76113) Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/shared/map_processor_type_to_form.tsx * Add code from #76948 * [Ingest Pipelines] Add descriptions for ingest processors A-D (#75975) * Fixing formatting issues identified by Prettier, part 2. * Fixing helpText labels. * Adding {value} object for dissect processor. * Incorporating reviewer feedback. * fix dropdown not rendering * Fixing typo. * add support for FormattedMessage in help text * fix TS * Updating some strings and trying to add code formatting. * fix formatted message * Editing some field descriptions. * Apply suggestions from code review Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com> * Trying to add EuiLink, plus edits. * fix help text for dissect processor * Incorporating reviewer feedback. * Trying to add another EUI element, plus edits. * fix date_index_name description text * Minor edit. * Fixing linter error. * Removing FunctionComponent, which was not read and caused build errors. Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com> Co-authored-by: Adam Locke <adam.locke@elastic.co> Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds descriptions for the following ingest processors:
Also updates several field descriptions for consistency with #75975.
Depends on #75975 for display implementation.
Relates to Ingest Node Processors Editors Forms
Checklist
Notes for reviewers
These changes don't include an interface for accessing/displaying the description copy. CI failure is expected until that's added (either in this PR or another).