Fix issue where defaultAppId redirect could fire outside home app #76415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Sep 2, 2020
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Sep 2, 2020
joshdover
added a commit
that referenced
this pull request
Sep 3, 2020
joshdover
added a commit
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #76018
Prior to this change,
history.listencould be called after the Home app had already redirected to thedefaultAppId. This would throw an exception in ScopedHistory, which would then in turn prevent the Home app's React tree from being unmounted. Since the tree was still active, it would cause the redirect logic to kick in some cases, even when the user was no longer on the Home app.Move the
history.listencall to be before the Home app's React tree is rendered prevents this problem by ensuring that the exception cannot be thrown and the Home app is properly unmounted every time.