Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Remove obsolete link #76419

Merged
merged 3 commits into from
Sep 2, 2020

Conversation

thomasneirynck
Copy link
Contributor

Summary

Closes #71338

Checklist

NA

For maintainers

@thomasneirynck thomasneirynck requested a review from a team as a code owner September 1, 2020 18:34
@thomasneirynck thomasneirynck added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Sep 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor

nreese commented Sep 1, 2020

This change seems to cause an entire page reload when creating a new map.

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review, tested in chrome

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
maps 3.3MB +53.0B 3.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 946e9f0 into elastic:master Sep 2, 2020
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps][Accessibility] <button> found within <a>
4 participants