[Ingest Manager] validate agent route using AJV instead kbn-config-schema #76546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate-agent-route-using-ajv
nchaulet
added
Ingest Management:beta2
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
approved these changes
Sep 3, 2020
jfsiii
reviewed
Sep 3, 2020
jfsiii
reviewed
Sep 3, 2020
jfsiii
reviewed
Sep 3, 2020
jfsiii
reviewed
Sep 3, 2020
| @@ -84,7 +116,10 @@ export const registerRoutes = (router: IRouter) => { | |||
| router.post( | |||
| { | |||
| path: AGENT_API_ROUTES.CHECKIN_PATTERN, | |||
| validate: PostAgentCheckinRequestSchema, | |||
| validate: { | |||
| params: makeValidator(PostAgentCheckinRequestParamsJSONSchema), | |||
jfsiii
reviewed
Sep 3, 2020
Co-authored-by: John Schulz <john.schulz@elastic.co>
…ate-agent-route-using-ajv
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Sep 4, 2020
nchaulet
added a commit
that referenced
this pull request
Sep 4, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 4, 2020
* master: (47 commits) Do not require id & description when creating a logstash pipeline (elastic#76616) Remove commented src/core/tsconfig file (elastic#76792) Replaced whitelistedHosts with allowedHosts in actions ascii docs (elastic#76731) [Dashboard First] Genericize Attribute Service (elastic#76057) [ci-metrics] unify distributable file count metrics (elastic#76448) [Security Solution][Detections] Handle conflicts on alert status update (elastic#75492) [eslint] convert to @typescript-eslint/no-unused-expressions (elastic#76471) [DOCS] Add default time range filter to advanced settings (elastic#76414) [Security Solution] Refactor NetworkTopNFlow to use Search Strategy (elastic#76249) [Dashboard] Update Index Patterns when Child Index Patterns Change (elastic#76356) [ML] Add option to Advanced Settings to set default time range filter for AD jobs (elastic#76347) Add CSM app to CODEOWNERS (elastic#76793) [Security Solution][Exceptions] - Updates exception item find sort field (elastic#76685) [Security Solution][Detections][Tech Debt] - Move to using common io-ts types (elastic#75009) [Lens] Drag dimension to replace (elastic#75895) URI encode the index names we fetch in the fetchIndices lib function. (elastic#76584) [Security Solution] Resolver retrieve entity id of documents without field mapped (elastic#76562) [Ingest Manager] validate agent route using AJV instead kbn-config-schema (elastic#76546) Updated non-dev usages of node-forge (elastic#76699) [Ingest Pipelines] Processor forms for processors K-S (elastic#75638) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #76281
Validate agent routes using AJV instead of
kbn-config-schemaaskbn-config-schemarely on Joi that is not the most performant JS library for validation.We should try to use AJV instead of JOI for the most frequently called of Fleet.
Perfomance improvements
Benchmark of the agent enroll request https://gist.github.com/nchaulet/894e00cf8bd649c3e1c2b063346cb621
I am working on running a Fleet load test against this change.