Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] Extend MlUrlGenerator to support other ML pages (#75696) #76561

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Sep 2, 2020

Backports the following commits to 7.x:

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
@qn895 qn895 added the backport label Sep 2, 2020
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

X-Pack Reporting API Integration Tests.x-pack/test/reporting_api_integration/reporting_and_security/usage·ts.Reporting APIs Usage initial state all counts are 0

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/76581

[00:00:00]       │
[00:00:00]         └-: Reporting APIs
[00:00:00]           └-> "before all" hook
[00:03:15]           └-: Usage
[00:03:15]             └-> "before all" hook
[00:03:15]             └-> "before all" hook
[00:03:15]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/kibana] Loading "mappings.json"
[00:03:15]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/kibana] Loading "data.json.gz"
[00:03:15]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [.kibana_2/CmHXcIFZRk6LjVs-Wjo4hA] deleting index
[00:03:15]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [.kibana_1/3AcicpP8RSCVTHu5OVw-6g] deleting index
[00:03:15]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/kibana] Deleted existing index [".kibana_2",".kibana_1"]
[00:03:15]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [.kibana_1] creating index, cause [api], templates [], shards [1]/[0]
[00:03:15]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/kibana] Created index ".kibana_1"
[00:03:15]               │ debg [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/kibana] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:03:15]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/kibana] Indexed 143 docs into ".kibana_1"
[00:03:15]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [.kibana_1/ISO-L4f9Q9atLGCWdMUNsQ] update_mapping [_doc]
[00:03:15]               │ debg Migrating saved objects
[00:03:18]               │ proc [kibana]   log   [21:08:09.063] [error][data][elasticsearch] [version_conflict_engine_exception]: [task:session_cleanup]: version conflict, document already exists (current version [4])
[00:03:18]               │ proc [kibana]   log   [21:08:09.170] [info][savedobjects-service] Creating index .kibana_2.
[00:03:18]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1]
[00:03:18]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] updating number_of_replicas to [0] for indices [.kibana_2]
[00:03:18]               │ proc [kibana]   log   [21:08:09.229] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:03:18]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [.kibana_2/xOpEX2OVTZeGXyzTfRbecQ] update_mapping [_doc]
[00:03:18]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [.kibana_2/xOpEX2OVTZeGXyzTfRbecQ] update_mapping [_doc]
[00:03:18]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [.kibana_2/xOpEX2OVTZeGXyzTfRbecQ] update_mapping [_doc]
[00:03:18]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [.kibana_2/xOpEX2OVTZeGXyzTfRbecQ] update_mapping [_doc]
[00:03:18]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [.kibana_2/xOpEX2OVTZeGXyzTfRbecQ] update_mapping [_doc]
[00:03:18]               │ proc [kibana]   log   [21:08:09.519] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:03:18]               │ proc [kibana]   log   [21:08:09.558] [info][savedobjects-service] Finished in 423ms.
[00:03:20]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [.kibana_2/xOpEX2OVTZeGXyzTfRbecQ] update_mapping [_doc]
[00:03:20]               │ proc [kibana]   log   [21:08:11.383] [error][data][elasticsearch] [version_conflict_engine_exception]: [task:session_cleanup]: version conflict, document already exists (current version [4])
[00:03:20]               │ proc [kibana]   log   [21:08:11.384] [error][data][elasticsearch] [version_conflict_engine_exception]: [space:default]: version conflict, document already exists (current version [1])
[00:03:20]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Loading "mappings.json"
[00:03:20]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Loading "data.json.gz"
[00:03:20]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [animals-dogs-2018-01-01/tlCd8isLT9Otr7qcg6wNyw] deleting index
[00:03:20]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Deleted existing index "animals-dogs-2018-01-01"
[00:03:20]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [animals-dogs-2018-01-01] creating index, cause [api], templates [], shards [5]/[1]
[00:03:20]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Created index "animals-dogs-2018-01-01"
[00:03:20]               │ debg [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] "animals-dogs-2018-01-01" settings {"index":{"number_of_replicas":"1","number_of_shards":"5"}}
[00:03:20]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [animals-dogs-2018-04-10/ohtUHSW9TYeAnI-d0G_zVA] deleting index
[00:03:20]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Deleted existing index "animals-dogs-2018-04-10"
[00:03:20]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [animals-dogs-2018-04-10] creating index, cause [api], templates [], shards [5]/[1]
[00:03:20]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Created index "animals-dogs-2018-04-10"
[00:03:20]               │ debg [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] "animals-dogs-2018-04-10" settings {"index":{"number_of_replicas":"1","number_of_shards":"5"}}
[00:03:20]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [animals-cats-2018-01-01/nEv7lPzvQgel60Y8LKWLoQ] deleting index
[00:03:20]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Deleted existing index "animals-cats-2018-01-01"
[00:03:20]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [animals-cats-2018-01-01] creating index, cause [api], templates [], shards [5]/[1]
[00:03:21]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Created index "animals-cats-2018-01-01"
[00:03:21]               │ debg [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] "animals-cats-2018-01-01" settings {"index":{"number_of_replicas":"1","number_of_shards":"5"}}
[00:03:21]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [animals-cats-2018-04-10/tT--0kSKQYKuemOOwj75xQ] deleting index
[00:03:21]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Deleted existing index "animals-cats-2018-04-10"
[00:03:21]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [animals-cats-2018-04-10] creating index, cause [api], templates [], shards [5]/[1]
[00:03:21]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Created index "animals-cats-2018-04-10"
[00:03:21]               │ debg [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] "animals-cats-2018-04-10" settings {"index":{"number_of_replicas":"1","number_of_shards":"5"}}
[00:03:21]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [dogbreeds/Zru1oF3WQE-4WWOh2Bw3IA] deleting index
[00:03:21]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Deleted existing index "dogbreeds"
[00:03:21]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [dogbreeds] creating index, cause [api], templates [], shards [5]/[1]
[00:03:21]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Created index "dogbreeds"
[00:03:21]               │ debg [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] "dogbreeds" settings {"index":{"number_of_replicas":"1","number_of_shards":"5"}}
[00:03:21]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [logstash-0/B3eXzeftRwaFq7mXizqIOw] deleting index
[00:03:21]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Deleted existing index "logstash-0"
[00:03:21]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1599076428131676821] [logstash-0] creating index, cause [api], templates [], shards [1]/[0]
[00:03:21]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Created index "logstash-0"
[00:03:21]               │ debg [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] "logstash-0" settings {"index":{"analysis":{"analyzer":{"makelogs_url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:03:30]               │ info progress: 13475
[00:03:30]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Indexed 6 docs into "animals-dogs-2018-01-01"
[00:03:30]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Indexed 6 docs into "animals-dogs-2018-04-10"
[00:03:30]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Indexed 6 docs into "animals-cats-2018-01-01"
[00:03:30]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Indexed 5 docs into "animals-cats-2018-04-10"
[00:03:30]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Indexed 6 docs into "dogbreeds"
[00:03:30]               │ info [/dev/shm/workspace/parallel/8/kibana/test/functional/fixtures/es_archiver/dashboard/current/data] Indexed 14005 docs into "logstash-0"
[00:03:31]               │ debg applying update to kibana config: {"defaultIndex":"0bf35f60-3dc9-11e8-8660-4d65aa086b3c"}
[00:03:32]               │ debg ReportingAPI.deleteAllReports
[00:03:32]             └-: initial state
[00:03:32]               └-> "before all" hook
[00:03:32]               └-> "before all" hook
[00:03:32]               └-> shows reporting as available and enabled
[00:03:32]                 └-> "before each" hook: global before each
[00:03:32]                 └- ✓ pass  (0ms) "Reporting APIs Usage initial state shows reporting as available and enabled"
[00:03:32]               └-> "after each" hook
[00:03:32]                 │ debg ReportingAPI.deleteAllReports
[00:03:33]               └-> all counts are 0
[00:03:33]                 └-> "before each" hook: global before each
[00:03:33]                 └- ✖ fail: Reporting APIs Usage initial state all counts are 0
[00:03:33]                 │      Error: expected 1 to equal 0
[00:03:33]                 │       at Assertion.assert (/dev/shm/workspace/parallel/8/kibana/packages/kbn-expect/expect.js:100:11)
[00:03:33]                 │       at Assertion.be.Assertion.equal (/dev/shm/workspace/parallel/8/kibana/packages/kbn-expect/expect.js:227:8)
[00:03:33]                 │       at Assertion.be (/dev/shm/workspace/parallel/8/kibana/packages/kbn-expect/expect.js:69:22)
[00:03:33]                 │       at Object.expectRecentPdfLayoutStats (test/reporting_api_integration/services.ts:162:75)
[00:03:33]                 │       at Context.apply (test/reporting_api_integration/reporting_and_security/usage.ts:61:22)
[00:03:33]                 │       at Object.apply (/dev/shm/workspace/parallel/8/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:30)
[00:03:33]                 │ 
[00:03:33]                 │ 

Stack Trace

Error: expected 1 to equal 0
    at Assertion.assert (/dev/shm/workspace/parallel/8/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/dev/shm/workspace/parallel/8/kibana/packages/kbn-expect/expect.js:227:8)
    at Assertion.be (/dev/shm/workspace/parallel/8/kibana/packages/kbn-expect/expect.js:69:22)
    at Object.expectRecentPdfLayoutStats (test/reporting_api_integration/services.ts:162:75)
    at Context.apply (test/reporting_api_integration/reporting_and_security/usage.ts:61:22)
    at Object.apply (/dev/shm/workspace/parallel/8/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:30)

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
ml 1385 +7 1378

async chunks size

id value diff baseline
ml 8.2MB +930.0B 8.2MB

page load bundle size

id value diff baseline
ml 582.7KB +6.1KB 576.6KB

distributable file count

id value diff baseline
total 47262 +2 47260

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@qn895 qn895 merged commit ef54fed into elastic:7.x Sep 3, 2020
@qn895 qn895 deleted the backport/7.x/pr-75696 branch September 3, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants