Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functional] Unskip vega tests and fix flakiness #76600

Merged
merged 2 commits into from
Sep 7, 2020
Merged

[Functional] Unskip vega tests and fix flakiness #76600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bf1f2d
[Functional] Unskip vega tests and fix flakiness
stratoula Sep 3, 2020
03adf8e
Merge branch 'master' into unskip-vega-tests
elasticmachine Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/functional/apps/visualize/_vega_chart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const retry = getService('retry');
const browser = getService('browser');

// FLAKY: https://github.com/elastic/kibana/issues/75699
describe.skip('vega chart in visualize app', () => {
describe('vega chart in visualize app', () => {
before(async () => {
log.debug('navigateToApp visualize');
await PageObjects.visualize.navigateToNewVisualization();
Expand Down
3 changes: 2 additions & 1 deletion test/functional/page_objects/vega_chart_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,9 @@ export function VegaChartPageProvider({
const aceGutter = await this.getAceGutterContainer();

await aceGutter.doubleClick();
await browser.pressKeys(Key.LEFT);
await browser.pressKeys(Key.RIGHT);
await browser.pressKeys(Key.LEFT);
await browser.pressKeys(Key.LEFT);
await browser.pressKeys(text);
}

Expand Down