Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy ui-apps-mixin #76604

Merged
merged 4 commits into from
Sep 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions src/legacy/server/kbn_server.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ import { HomeServerPluginSetup } from '../../plugins/home/server';
// lot of legacy code was assuming this type only had these two methods
export type KibanaConfig = Pick<LegacyConfig, 'get' | 'has'>;

export interface UiApp {
getId(): string;
}

// Extend the defaults with the plugins and server methods we need.
declare module 'hapi' {
interface PluginProperties {
Expand All @@ -66,13 +62,6 @@ declare module 'hapi' {
interface Server {
config: () => KibanaConfig;
savedObjects: SavedObjectsLegacyService;
injectUiAppVars: (pluginName: string, getAppVars: () => { [key: string]: any }) => void;
getHiddenUiAppById(appId: string): UiApp;
addScopedTutorialContextFactory: (
scopedTutorialContextFactory: (...args: any[]) => any
) => void;
getInjectedUiAppVars: (pluginName: string) => { [key: string]: any };
getUiNavLinks(): Array<{ _id: string }>;
logWithMetadata: (tags: string[], message: string, meta: Record<string, any>) => void;
newPlatform: KbnServer['newPlatform'];
}
Expand All @@ -82,10 +71,6 @@ declare module 'hapi' {
getBasePath(): string;
getUiSettingsService(): IUiSettingsClient;
}

interface ResponseToolkit {
renderAppWithDefaultConfig(app: UiApp): ResponseObject;
}
}

type KbnMixinFunc = (kbnServer: KbnServer, server: Server, config: any) => Promise<any> | void;
Expand Down
92 changes: 0 additions & 92 deletions src/legacy/ui/ui_apps/__snapshots__/ui_apps_mixin.test.js.snap

This file was deleted.

Loading