-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using test_user with minimum privileges for lens functional ui tests #76673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmivkulkarni
added
test_xpack_functional
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Feature:Lens
v7.10.0
labels
Sep 3, 2020
rashmivkulkarni
force-pushed
the
lens
branch
from
September 4, 2020 18:34
201d1a7
to
9884ab0
Compare
LeeDr
reviewed
Sep 15, 2020
LeeDr
reviewed
Sep 15, 2020
@elasticmachine merge upstream |
ready for review @LeeDr |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
LeeDr
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - only code reviewed and verified Jenkins results
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Sep 16, 2020
…lastic#76673) * lens modified privs * lens reporting test * new role added -global_dashboard_all * remove unwanted file * added the reverted file * precommit hook fix * moved the navigateToApp to the before method * moving the navigateToApp to before method * closing the alert window if open in the test_user method * adding the false param * addressed review comments * added common PageObjects * removed common Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rashmivkulkarni
added a commit
that referenced
this pull request
Sep 16, 2020
…76673) (#77651) * lens modified privs * lens reporting test * new role added -global_dashboard_all * remove unwanted file * added the reverted file * precommit hook fix * moved the navigateToApp to the before method * moving the navigateToApp to before method * closing the alert window if open in the test_user method * adding the false param * addressed review comments * added common PageObjects * removed common Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Lens
release_note:skip
Skip the PR/issue when compiling release notes
test_xpack_functional
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta issue : #60815
Summary
This PR replaces
elastic
superuser withtest_user
with minimum privileges assigned.Checklist
Unit or functional tests were updated or added to match the most common scenarios