Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Add Overview landing page/plugin #76734

Merged
merged 14 commits into from
Sep 9, 2020
Merged

[Enterprise Search] Add Overview landing page/plugin #76734

merged 14 commits into from
Sep 9, 2020

Commits on Sep 9, 2020

  1. [public] Register Enterprise search plugin 

    + move new Home strings to constants
    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    b3b8363 View commit details
    Browse the repository at this point in the history

  2. [server] Register plugin access/visibility

    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    71fb659 View commit details
    Browse the repository at this point in the history

  3. Set up Enterprise Search Kibana Chrome 

    - Add SetEnterpriseSearchChrome
- Update Enterprise Search breadcrumbs to link to new overview plugin (+ update overview plugin URL per team discussion)
  - Add ability to break out of React Router basename by not using history.createhref
  - Update createHref mock to more closely match Kibana urls (adding /app prefix)
- Minor documentation fix
    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    705e60c View commit details
    Browse the repository at this point in the history

  4. Set up Enterprise Search plugin telemetry 

    - client-side: SendEnterpriseSearchTelemetry
- server-side: register saved objects, usage collector, etc.
    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    feec1a5 View commit details
    Browse the repository at this point in the history

  5. Enterprise search overview views (#23) 

    * Add formatTestSubj util

This allows us to correctly format strings into our casing for data-test-subj attrs

* Add images and stylesheet

* Add product card component

* Add index component

* Remove unused styles
    @scottybollinger @cee-chen
    scottybollinger authored and cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    8b805fd View commit details
    Browse the repository at this point in the history

  6. Fix inter-plugin links 

    - by add shouldNotCreateHref prop to RR helpers
- similiar to breadcrumb change
    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    c1a4655 View commit details
    Browse the repository at this point in the history

  7. Fix/clean up CSS 

    - Prefer EUI components over bespoke CSS (e.g. EuiCard)
- Remove unused or unspecific CSS
- Pull out product card CSS to its component
- Fix kebab-cased CSS classes to camelCased
    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    38a1dc2 View commit details
    Browse the repository at this point in the history

  8. Clean up ProductCard props 

    - Prefer passing in our plugin consts instead of separate props
- Move productCardDescription to constants
- Update tests
    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    d82cd1b View commit details
    Browse the repository at this point in the history

  9. Add telemetry clicked actions to product buttons 

    + revert data-test-subj strings to previous implementation
+ prune format_test_subj helper by using lodash util directly
    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    78bcc05 View commit details
    Browse the repository at this point in the history

  10. [PR feedback] Add new plugin to applicationUsageSchema per telemetry … 

    …team request
    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    ed83698 View commit details
    Browse the repository at this point in the history

  11. Fix failing functional navLinks test

    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    66410e1 View commit details
    Browse the repository at this point in the history

  12. Fix telemetry schema test

    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    e9e64eb View commit details
    Browse the repository at this point in the history

  13. [Perf] Optimize assets size by switching from 300kb SVG to 25kb PNG

    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    302035c View commit details
    Browse the repository at this point in the history

  14. Only show product cards if the user has access to that product 

    - adds access checks
- fixes flex/CSS to show one card at a time
    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    8718473 View commit details
    Browse the repository at this point in the history