Adds back in custom images for reporting + tests #76810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelgriffith
added
bug
joelgriffith
commented
Sep 4, 2020
| }), | ||
| type: 'image', | ||
| schema: schema.nullable(schema.byteSize({ max: '200kb' })), | ||
| category: [PLUGIN_ID], |
There was a problem hiding this comment.
schema is required by types for register, however validation is what the client is looking at for validating that the size is appropriate
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
This was referenced Sep 4, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 7, 2020
* master: [APM] Use observer.hostname instead of observer.name (elastic#76074) Legacy logging: fix remoteAddress being duplicated in userAgent field (elastic#76751) Remove legacy deprecation adapter (elastic#76753) [Security Solution][Detections] Rule forms cleanup (elastic#76138) Adds back in custom images for reporting + tests (elastic#76810) [APM] Fix overlapping transaction names (elastic#76083) [Ingest Pipelines] Add descriptions for ingest processors A-D (elastic#75975)
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
joelgriffith
pushed a commit
that referenced
this pull request
Sep 8, 2020
joelgriffith
pushed a commit
that referenced
this pull request
Sep 8, 2020
kibanamachine
removed
the
backport missing
dgieselaar
pushed a commit
to dgieselaar/kibana
that referenced
this pull request
Sep 9, 2020
…stic#76825) # Conflicts: # x-pack/plugins/reporting/server/plugin.ts Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back in the missing reporting PDF custom image option (regression).