Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snapshot & Restore] Fix empty string policy indices #76855

Merged
merged 1 commit into from
Sep 8, 2020
Merged

[Snapshot & Restore] Fix empty string policy indices #76855

merged 1 commit into from
Sep 8, 2020

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Sep 7, 2020 •
edited
Loading

Summary

When creating an ILM policy and reaching form 2 of the creation wizard there is a toggle to select all data streams and indices. When unselecting this toggle, the default empty index patterns combo box is displayed. Leaving this blank and selecting "next" on the form does not block the user (as this field is required). Returning to the form the "all data streams and indices" toggle is on (which seems like a sane default). Deselecting all again reveals an empty index pattern.

Screenshots

This should not be possible 👇🏻
Screenshot 2020-09-07 at 11 18 10

How to reproduce

gif

ILM_policy_bug

Checklist

For maintainers

Release note

Fixed a bug in the snapshot and restore policy creation form that allowed a policy to be created without an index specified.

@jloleysens jloleysens added Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.2 labels Sep 7, 2020
@jloleysens jloleysens requested a review from a team as a code owner September 7, 2020 09:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@jloleysens jloleysens changed the title [ILM] Fix empty string policy indices [Snapshot & Restore] Fix empty string policy indices Sep 7, 2020
@jloleysens jloleysens added Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI and removed Feature:ILM labels Sep 7, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
snapshotRestore 761.6KB +34.0B 761.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens requested review from yuliacech and removed request for alisonelizabeth September 7, 2020 14:12
yuliacech
yuliacech approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jloleysens,
I tested the code locally and all worked for me. Changes look good to me too!

@cjcenizal
Copy link
Contributor

@jloleysens Great job with this one, too! Is this fixing a bug from a prior release? If so, can we add the release_note:fix label and add a release note?

@jloleysens jloleysens added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Sep 8, 2020
@jloleysens jloleysens merged commit eecb0e5 into elastic:master Sep 8, 2020
@jloleysens jloleysens deleted the ilm/fix/policy-validation branch September 8, 2020 07:59
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 8, 2020
@jloleysens
fix empty string in selected indices (elastic#76855)
8c270d9
@jloleysens jloleysens mentioned this pull request Sep 8, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 8, 2020
@jloleysens
fix empty string in selected indices (elastic#76855)
7e181eb
@jloleysens jloleysens mentioned this pull request Sep 8, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 8, 2020
@jloleysens
Merge branch 'ilm/fix/pre-existing-policy-with-no-existing-repository…
1a85d85 
…' of github.com:jloleysens/kibana into ilm/fix/pre-existing-policy-with-no-existing-repository

* 'ilm/fix/pre-existing-policy-with-no-existing-repository' of github.com:jloleysens/kibana:
  fix empty string in selected indices (elastic#76855)
  [Security Solution] Refactor OverviewHost and OverviewNetwork to use Search Strategy (elastic#76409)
  Use Search API in Timelion (sync) (elastic#75115)
  [telemetry] expose getIsOptedIn function in plugin start contract (elastic#75143)
  [ILM] Clean up remaining js files and any typings (elastic#76803)
  [Logs UI] Shared `<LogStream />` component (elastic#76262)
  [Security Solution] Add unit test for all hosts (elastic#76752)
  [Security Solution] Add unit test for authentications search strategy (elastic#76665)
  Do not apply search source data for tsvb (elastic#75137)
  [Security Solution] Refactor NetworkDns to use Search Strategy (elastic#76250)
  [SECURITY SOLUTION] Adds 'cypress:open-as-ci' command (elastic#76125)
  [Logs UI] Update alert executor tests (elastic#75764)
  [Functional] Unskip vega tests and fix flakiness (elastic#76600)
  [Data] Query String Input accepts classname prop (elastic#76848)
  [ML] Swim lane pagination for viewing by job id (elastic#76847)
  [Security Solution] Refactor MatrixHistogram to use Search Strategy (elastic#76603)
  [APM] Use the outcome field to calculate the transaction error rate chart (elastic#75528)
  [APM] Use observer.hostname instead of observer.name (elastic#76074)
  Legacy logging: fix remoteAddress being duplicated in userAgent field (elastic#76751)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 8, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/data-tier…
8b1f1dd 
…s-for-710

* 'master' of github.com:elastic/kibana:
  [Search] Use async es client endpoints (elastic#76872)
  fix empty string in selected indices (elastic#76855)
  [Security Solution] Refactor OverviewHost and OverviewNetwork to use Search Strategy (elastic#76409)
  Use Search API in Timelion (sync) (elastic#75115)
  [telemetry] expose getIsOptedIn function in plugin start contract (elastic#75143)
  [ILM] Clean up remaining js files and any typings (elastic#76803)
  [Logs UI] Shared `<LogStream />` component (elastic#76262)
  [Security Solution] Add unit test for all hosts (elastic#76752)
  [Security Solution] Add unit test for authentications search strategy (elastic#76665)
  Do not apply search source data for tsvb (elastic#75137)
  [Security Solution] Refactor NetworkDns to use Search Strategy (elastic#76250)
  [SECURITY SOLUTION] Adds 'cypress:open-as-ci' command (elastic#76125)
  [Logs UI] Update alert executor tests (elastic#75764)
  [Functional] Unskip vega tests and fix flakiness (elastic#76600)
  [Data] Query String Input accepts classname prop (elastic#76848)
  [ML] Swim lane pagination for viewing by job id (elastic#76847)
  [Security Solution] Refactor MatrixHistogram to use Search Strategy (elastic#76603)
  [APM] Use the outcome field to calculate the transaction error rate chart (elastic#75528)
  [APM] Use observer.hostname instead of observer.name (elastic#76074)
  Legacy logging: fix remoteAddress being duplicated in userAgent field (elastic#76751)

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/__jest__/components/edit_policy.test.tsx
#	x-pack/plugins/index_lifecycle_management/common/types/index.ts
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/phases/warm_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/services/api.ts
jloleysens added a commit that referenced this pull request Sep 8, 2020
@jloleysens
fix empty string in selected indices (#76855) (#76902)
26d71c1
jloleysens added a commit that referenced this pull request Sep 8, 2020
@jloleysens
fix empty string in selected indices (#76855) (#76903)
e5a6d56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

Assignees
No one assigned
Labels
Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.9.2 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jloleysens @elasticmachine @kibanamachine @cjcenizal @yuliacech