[Monitoring] Fix improper lodash syntax #77105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
release_note:fix
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
igoristic
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
Looking good 👍
ps: Was also wondering if this: https://github.com/chrisronline/kibana/blob/monitoring/lodash_lol/x-pack/plugins/monitoring/server/lib/cluster/__tests__/get_clusters_state.js#L58 is also affected. But, I guess we'll now depending if the tests pass or fail
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Sep 10, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Sep 10, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
chrisronline
added a commit
that referenced
this pull request
Sep 10, 2020
chrisronline
added a commit
that referenced
this pull request
Sep 10, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 14, 2020
…s-for-710 * 'master' of github.com:elastic/kibana: (65 commits) Separate url forwarding logic and legacy services (elastic#76892) Bump yargs-parser to v13.1.2+ (elastic#77009) [Ingest Manager] Shared Fleet agent policy action (elastic#76013) [Search] Re-add support for aborting when a connection is closed (elastic#76470) [Search] Remove long-running query pop-up (elastic#75385) [Monitoring] Fix UI error when alerting is not available (elastic#77179) do not log plugin id format warning in dist mode (elastic#77134) [ML] Improving client side error handling (elastic#76743) [Alerting][Connectors] Refactor IBM Resilient: Generic Implementation (phase one) (elastic#74357) [Docs] some basic searchsource api docs (elastic#77038) add cGroupOverrides to the legacy config (elastic#77180) Change saved object bulkUpdate to work across multiple namespaces (elastic#75478) [Security Solution][Resolver] Replace Selectable popover with badges (elastic#76997) Removing ml-state index from archive (elastic#77143) [Security Solution] Add unit tests for histograms (elastic#77081) [Lens] Filters aggregation (elastic#75635) [Enterprise Search] Update WS Overview logic to use new config data (elastic#77122) Cleanup type output before building new types (elastic#77211) [Security Solution] Use safe type in resolver backend (elastic#76969) Use proper lodash syntax (elastic#77105) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #73298
#69868 introduced a new major version of lodash which had an unexpected effect on a piece of our code that formats our raw data for use in our visualizations.
The code in question is:
and
This works in lodash@3: https://codepen.io/chrisronline/pen/xxVWVBB?editors=1111
However, it does not work in lodash@4: https://codepen.io/chrisronline/pen/WNwzwgj?editors=1111
This PR fixes the usage to proper lodash usage.