Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test user to maps functional tests #77119

Merged
merged 8 commits into from
Sep 15, 2020
Merged

Adding test user to maps functional tests #77119

merged 8 commits into from
Sep 15, 2020

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Sep 9, 2020

Meta issue - #60815

@bhavyarm bhavyarm self-assigned this Sep 9, 2020
@bhavyarm bhavyarm added test_xpack_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 9, 2020
@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm bhavyarm marked this pull request as ready for review September 10, 2020 22:36
@bhavyarm bhavyarm requested a review from a team as a code owner September 10, 2020 22:36
rashmivkulkarni
rashmivkulkarni approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Would be also good if you could extract the common roles the test_user is using -for each of these files into index.ts before method ?

LGTM.

thomasneirynck
thomasneirynck approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, lgtm, thx!

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm bhavyarm merged commit 5161049 into elastic:master Sep 15, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 17, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 77119 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 77119 or prevent reminders by adding the backport:skip label.

@bhavyarm bhavyarm mentioned this pull request Sep 21, 2020
Merged
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Sep 21, 2020
@bhavyarm
Adding test user to maps functional tests (elastic#77119)
8fc715c
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 21, 2020
bhavyarm added a commit that referenced this pull request Sep 21, 2020
@bhavyarm
Adding test user to maps functional tests (#77119) (#78020)
eb3234e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@rashmivkulkarni rashmivkulkarni rashmivkulkarni approved these changes

@LeeDr LeeDr Awaiting requested review from LeeDr

Assignees

@bhavyarm bhavyarm

Labels
release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhavyarm @kibanamachine @thomasneirynck @rashmivkulkarni @elasticmachine