[ML] Improve performance of job exists check #77156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
requested review from
peteharverson,
walterra,
legrego and
droberts195
jgowdyelastic
added
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
legrego
approved these changes
Sep 10, 2020
| results[jobId] = body.count > 0; | ||
| } catch (e) { | ||
| // if a non-wildcarded job id is supplied, the get jobs endpoint will 404 | ||
| if (e.body.status !== 404) { |
There was a problem hiding this comment.
nit: if the caught error isn't returned from ES, but instead is the result of an unexpected runtime error, then there's a possibility that you won't have a body property defined. Something like this might be more robust:
Suggested change
| if (e.body.status !== 404) { | |
| if (e.body?.status !== 404) { |
peteharverson
approved these changes
Sep 10, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Sep 10, 2020
* [ML] Improve performance of job exists check * adding tests * possible undefined error body
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Sep 10, 2020
* [ML] Improve performance of job exists check * adding tests * possible undefined error body # Conflicts: # x-pack/plugins/ml/server/models/job_service/jobs.ts
jgowdyelastic
added a commit
that referenced
this pull request
Sep 10, 2020
* [ML] Improve performance of job exists check (#77156) * [ML] Improve performance of job exists check * adding tests * possible undefined error body # Conflicts: # x-pack/plugins/ml/server/models/job_service/jobs.ts * fixing type error
jgowdyelastic
added a commit
that referenced
this pull request
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint
/api/ml/jobs/jobs_existdoes not need to use a regex to check the job ids as the underlying es endpoint accepts wildcarded ids.Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately