[Security Solution] Refactor Timeline Events to use Search Strategy #77205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…details-search-strategy
|
Pinging @elastic/siem (Team:SIEM) |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
angorayc
reviewed
Sep 16, 2020
| @@ -129,8 +129,6 @@ const mapDispatchToProps = (dispatch: Dispatch, { timelineId }: OwnProps) => ({ | |||
| dispatch(timelineActions.updateDescription({ id, description })), | |||
| updateIsFavorite: ({ id, isFavorite }: { id: string; isFavorite: boolean }) => | |||
| dispatch(timelineActions.updateIsFavorite({ id, isFavorite })), | |||
| updateIsLive: ({ id, isLive }: { id: string; isLive: boolean }) => | |||
| dispatch(timelineActions.updateIsLive({ id, isLive })), | |||
There was a problem hiding this comment.
could we also remove updateIsLive from reducer and actions as well, seems it is never triggered.
angorayc
approved these changes
Sep 16, 2020
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Sep 16, 2020
1 task
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before:
After:
Checklist