Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Update enterpriseSearchRequestHandler to manage range of errors + add handleAPIErrors helper #77258

Merged
merged 8 commits into from
Sep 15, 2020
Merged

[Enterprise Search] Update enterpriseSearchRequestHandler to manage range of errors + add handleAPIErrors helper #77258

merged 8 commits into from
Sep 15, 2020

Commits on Sep 11, 2020

  1. Update/refactor EnterpriseSearchRequestHandler to manage internal end… 

    …point error behavior

+ pull out / refactor all errors into their own methods instead of relying on a single 'error connecting' message
    @cee-chen
    cee-chen committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    e57009c View commit details
    Browse the repository at this point in the history

  2. Fix http interceptor bug preventing 4xx/5xx responses from being caught

    @cee-chen
    cee-chen committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    0e1f2eb View commit details
    Browse the repository at this point in the history

  3. Add handleAPIError helper 

    - New and improved from ent-search - this one automatically sets flash messages for you so you don't have to pass in a callback!
    @cee-chen
    cee-chen committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    2b949c5 View commit details
    Browse the repository at this point in the history

  4. Fix type check

    @cee-chen
    cee-chen committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    ab889ee View commit details
    Browse the repository at this point in the history

  5. [Feedback] Add option to queue flash messages to handleAPIError 

    - Should be hopefully useful for calls that need to queue an error and then redirect to another page
    @cee-chen
    cee-chen committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    dcdd872 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. PR feedback: Add test case for bodies flagged as JSON which are not

    @cee-chen
    cee-chen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    9bf8069 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into handle-api-errors

    @cee-chen
    cee-chen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    5287c75 View commit details
    Browse the repository at this point in the history

  3. Rename handleAPIError to flashAPIErrors

    @cee-chen
    cee-chen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    ad4f8fd View commit details
    Browse the repository at this point in the history