-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow legacy imports size respect savedObjects.maxImportPayloadBytes
config
#77409
Merged
joshdover
merged 4 commits into
elastic:master
from
joshdover:legacy-import-export-maxbytes
Sep 16, 2020
Merged
Allow legacy imports size respect savedObjects.maxImportPayloadBytes
config
#77409
joshdover
merged 4 commits into
elastic:master
from
joshdover:legacy-import-export-maxbytes
Sep 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
release_note:enhancement
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Feature:Saved Objects
v8.0.0
v7.10.0
labels
Sep 14, 2020
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
approved these changes
Sep 15, 2020
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/drilldowns/explore_data_panel_action·ts.dashboard drilldowns Explore underlying data - panel action carries over panel time rangeStandard Out
Stack Trace
Build metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Sep 16, 2020
This was referenced Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Saved Objects
release_note:enhancement
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This helps alleviate elastic/beats#20432 in some situations by allowing the legacy import API to accept file sizes up to the value configured in
savedObjects.maxImportPayloadBytes
which is 10MB by default. Keep in mind that proxies in front of Kibana often have a lower limit in place, so Beats may still have problems importing dashboards in some cases. For example, the default payload size limit for Nginx is 1MB.Release Note
The deprecated Dashboard Import API (
POST /api/kibana/dashboards/import
) now accepts filesizes up to thesavedObjects.maxImportPayloadBytes
configuration which is 10MB by default.Checklist
Delete any items that are not applicable to this PR.
For maintainers