[data.search.SearchSource] Unify FetchHandler types & add onResponse/callMsearch. #77430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #65069
Summary
This PR cleans up a few remaining items so that
SearchSource
can be moved intocommon
and shared between client & server:handleResponse
and replaces with a newonResponse
callback that's provided toSearchSource
handleResponse
is used in the client to display errors in the UI; on the server it will just pass along the response unchangedcore.http
which has different client & server APIs, and replaces withcallMsearch
callMsearch
is a simple helper for calling the/internal/_msearch
endpoint, and abstracts away the usage of thehttp
serviceconfig
inFetchHandlers
togetConfig
for consistency with other areas of thedata
pluginSearchSourceDependencies
fromFetchHandlers
to remove duplicated typescallMsearch
andloadingCount$
underlegacy
inFetchHandlers
, to make it clear what configuration can be removed fromSearchSource
whenever the legacy default search strategy is removed.Testing
This is a refactoring; no functional changes were introduced. Most of the updates here affect the behavior of Discover / Visualizations / Dashboards when the
courier:batchSearches
advanced setting is enabled.