Migrate /api/settings to KP #77554
Merged
Migrate /api/settings to KP #77554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
💚 Build SucceededBuild metricsdistributable file count
History
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Sep 16, 2020
Comment on lines
+43
to
+50
| interface EmailSettingData { | ||
| xpack: { default_admin_email: string | null }; | ||
| } | ||
|
|
||
| export interface KibanaSettingsCollector extends Collector<EmailSettingData | undefined> { | ||
| getEmailValueStructure(email: string | null): EmailSettingData; | ||
| } | ||
|
|
There was a problem hiding this comment.
Be careful when backporting this, there is a difference between master and 7.x in the getEmailValueStructure implementation (the PR does not impact this so it should be fine, but just saying)
chrisronline
approved these changes
Sep 16, 2020
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Sep 16, 2020
# Conflicts: # docs/developer/plugin-list.asciidoc # x-pack/plugins/monitoring/server/kibana_monitoring/collectors/get_settings_collector.ts # x-pack/plugins/xpack_legacy/kibana.json # x-pack/plugins/xpack_legacy/server/plugin.ts
pgayvallet
pushed a commit
that referenced
this pull request
Sep 17, 2020
* Migrate /api/settings to KP (#77554) # Conflicts: # docs/developer/plugin-list.asciidoc # x-pack/plugins/monitoring/server/kibana_monitoring/collectors/get_settings_collector.ts # x-pack/plugins/xpack_legacy/kibana.json # x-pack/plugins/xpack_legacy/server/plugin.ts * Fix lint Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #76416
This migrates the
/api/settingsendpoint from the legacy xpack_main plugin to the xpack_legacy plugin. This plugin can be deleted once Beats is no longer using this (in 8.0).Much of this PR is similar to #76054
Checklist