Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Move LicenseContext to Kea #78231

Merged
merged 5 commits into from
Sep 23, 2020
Merged

[Enterprise Search] Move LicenseContext to Kea #78231

merged 5 commits into from
Sep 23, 2020

Commits on Sep 22, 2020

  1. Fix licensing to use start service + refactor 

    - I noticed my IDE complaining that we were using LicensingPluginSetup (deprecated) instead of LicensingPluginStart, and decided to factor plugin.ts to DRY out / ensure all the dependencies we were passing on app mount were start services and not setup

- The number of args we were passing to renderApp was getting a little ridiculous, so I created small helpers to group them up by type (Kibana's args (dependencies/services) vs our plugin's args (data, config, etc.)

+ bonus remove unused CoreStart type/arg
    @cee-chen
    cee-chen committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    450c6b7 View commit details
    Browse the repository at this point in the history

  2. Add LicensingLogic + mount 

    - replaces useObservable with a manual subscription that updates the license value/state
- moves hasXLicense checks to selectors vs helper functions
    @cee-chen
    cee-chen committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    169d8bb View commit details
    Browse the repository at this point in the history

  3. Update components w/ license checks to use LicensingLogic

    @cee-chen
    cee-chen committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    06293f0 View commit details
    Browse the repository at this point in the history

  4. Update tests for components now calling LicensingLogic 

    - Add mockLicensingValues to basic kea mock
- Minor comment update to mockAllValues obj that I forgot to add in a previous PR
    @cee-chen
    cee-chen committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    d4dd185 View commit details
    Browse the repository at this point in the history

  5. 🔥 Remove old LicensingContext

    @cee-chen
    cee-chen committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    6fa43f9 View commit details
    Browse the repository at this point in the history