[Canvas] Move Handlebars and Flot dependencies out of main bundle #78542

crob611 · 2020-09-25T16:58:31Z

Summary

Moving some dependencies around.

crob611 · 2020-09-28T13:51:29Z

@elasticmachine merge upstream

elasticmachine · 2020-09-28T14:13:40Z

Pinging @elastic/kibana-canvas (Team:Canvas)

poffdeluxe

Changes look good to me. Two questions though:

Will the modules get imported each time the rendering happens? Or is the system smart enough to load just once?
Will this affect the modules that get bundled in the shareable runtime at all? (i'm not sure how the runtime packager figures out the packages it needs)

crob611 · 2020-09-30T20:49:20Z

@elasticmachine merge upstream

kibanamachine · 2020-09-30T22:23:24Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 08785d5
Flaky suites:
- kibana-ciGroup1

Test Failures

Chrome UI Functional Tests.test/functional/apps/context/_context_navigation·js.context app discover - context - back navigation "before all" hook for "should go back after loading"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:17]         └-: context app
[00:00:17]           └-> "before all" hook
[00:00:17]           └-> "before all" hook
[00:00:17]             │ info [logstash_functional] Loading "mappings.json"
[00:00:17]             │ info [logstash_functional] Loading "data.json.gz"
[00:00:17]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0]
[00:00:17]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.22][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.22][0]]"
[00:00:17]             │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:00:17]             │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:17]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0]
[00:00:17]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.20][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.20][0]]"
[00:00:17]             │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:00:17]             │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:17]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0]
[00:00:18]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.21][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.21][0]]"
[00:00:18]             │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:00:18]             │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:27]             │ info progress: 3006
[00:00:37]             │ info progress: 10826
[00:00:40]             │ info [logstash_functional] Indexed 4633 docs into "logstash-2015.09.22"
[00:00:40]             │ info [logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:00:40]             │ info [logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:00:40]             │ info [visualize] Loading "mappings.json"
[00:00:40]             │ info [visualize] Loading "data.json"
[00:00:40]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [.kibana_1/WhRLxVgCSR6bbTOCf77-0A] deleting index
[00:00:40]             │ info [visualize] Deleted existing index [".kibana_1"]
[00:00:40]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [.kibana] creating index, cause [api], templates [], shards [1]/[1]
[00:00:40]             │ info [visualize] Created index ".kibana"
[00:00:40]             │ debg [visualize] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:00:40]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [.kibana/Q_ur9ja8RwOl9tYE92Yq5Q] update_mapping [_doc]
[00:00:40]             │ info [visualize] Indexed 12 docs into ".kibana"
[00:00:40]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [.kibana/Q_ur9ja8RwOl9tYE92Yq5Q] update_mapping [_doc]
[00:00:40]             │ debg Migrating saved objects
[00:00:40]             │ proc [kibana]   log   [21:11:16.701] [info][savedobjects-service] Creating index .kibana_2.
[00:00:40]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1]
[00:00:40]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] updating number_of_replicas to [0] for indices [.kibana_2]
[00:00:41]             │ proc [kibana]   log   [21:11:16.786] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:00:41]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1]
[00:00:41]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] updating number_of_replicas to [0] for indices [.kibana_1]
[00:00:41]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [.tasks] creating index, cause [auto(task api)], templates [], shards [1]/[1]
[00:00:41]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] updating number_of_replicas to [0] for indices [.tasks]
[00:00:41]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] 841 finished with response BulkByScrollResponse[took=72.7ms,timed_out=false,sliceId=null,updated=0,created=12,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:00:41]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [.kibana/Q_ur9ja8RwOl9tYE92Yq5Q] deleting index
[00:00:41]             │ proc [kibana]   log   [21:11:17.196] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:00:41]             │ proc [kibana]   log   [21:11:17.230] [error][savedobjects-service] Error: Unable to migrate the corrupt Saved Object document index-pattern:test_index*. To prevent Kibana from performing a migration on every restart, please delete or fix this document by ensuring that the namespace and type in the document's id matches the values in the namespace and type fields.
[00:00:41]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [.kibana_2/AMLAeX1ASy2EBvKXL7sU9Q] update_mapping [_doc]
[00:00:41]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [.kibana_2/AMLAeX1ASy2EBvKXL7sU9Q] update_mapping [_doc]
[00:00:41]             │ proc [kibana]   log   [21:11:17.351] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:00:41]             │ proc [kibana]   log   [21:11:17.394] [info][savedobjects-service] Finished in 697ms.
[00:00:41]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:00:41]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1601499009699019426] [.kibana_2/AMLAeX1ASy2EBvKXL7sU9Q] update_mapping [_doc]
[00:00:43]             │ debg replacing kibana config doc: {"defaultIndex":"logstash-*"}
[00:00:44]             │ debg navigating to discover url: http://localhost:61221/app/discover#/
[00:00:44]             │ debg navigate to: http://localhost:61221/app/discover#/
[00:00:44]             │ debg browser[INFO] http://localhost:61221/app/discover?_t=1601500279796#/ 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:44]             │
[00:00:44]             │ debg browser[INFO] http://localhost:61221/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:44]             │ debg ... sleep(700) start
[00:00:45]             │ debg ... sleep(700) end
[00:00:45]             │ debg returned from get, calling refresh
[00:00:45]             │ debg browser[INFO] http://localhost:61221/app/discover?_t=1601500279796#/ 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:45]             │
[00:00:45]             │ debg browser[INFO] http://localhost:61221/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:45]             │ debg currentUrl = http://localhost:61221/app/discover#/
[00:00:45]             │          appUrl = http://localhost:61221/app/discover#/
[00:00:45]             │ debg TestSubjects.find(kibanaChrome)
[00:00:45]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:45]             │ debg ... sleep(501) start
[00:00:46]             │ debg ... sleep(501) end
[00:00:46]             │ debg browser[INFO] http://localhost:61221/36800/bundles/core/core.entry.js 26:218333 "Detected an unhandled Promise rejection.
[00:00:46]             │      Error: Saved field \"@timestamp\" is invalid for use with the \"Date Histogram\" aggregation. Please select a new field."
[00:00:46]             │ERROR browser[SEVERE] http://localhost:61221/36800/bundles/plugin/data/data.plugin.js 5:524969 Uncaught Error: Saved field "@timestamp" is invalid for use with t…istogram" aggregation. Please select a new field.
[00:00:46]             │ debg in navigateTo url = http://localhost:61221/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:00:46]             │ debg --- retry.try error: URL changed, waiting for it to settle
[00:00:46]             │ debg ... sleep(501) start
[00:00:47]             │ debg ... sleep(501) end
[00:00:47]             │ debg in navigateTo url = http://localhost:61221/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:00:47]             │ debg TestSubjects.exists(statusPageContainer)
[00:00:47]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:00:49]             │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:00:50]           └-: discover - context - back navigation
[00:00:50]             └-> "before all" hook
[00:00:50]             └-> "before all" hook
[00:00:50]               │ debg applying update to kibana config: {"timepicker:timeDefaults":"{ \"from\": \"2015-09-18T06:31:44.000Z\", \"to\": \"2015-09-23T18:31:44.000Z\"}"}
[00:00:51]               │ debg navigating to discover url: http://localhost:61221/app/discover#/
[00:00:51]               │ debg navigate to: http://localhost:61221/app/discover#/
[00:00:51]               │ debg browser[INFO] http://localhost:61221/app/discover?_t=1601500286850#/ 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:51]               │
[00:00:51]               │ debg browser[INFO] http://localhost:61221/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:51]               │ debg ... sleep(700) start
[00:00:51]               │ debg ... sleep(700) end
[00:00:51]               │ debg returned from get, calling refresh
[00:00:52]               │ debg browser[INFO] http://localhost:61221/app/discover?_t=1601500286850#/ 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:52]               │
[00:00:52]               │ debg browser[INFO] http://localhost:61221/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:52]               │ debg currentUrl = http://localhost:61221/app/discover#/
[00:00:52]               │          appUrl = http://localhost:61221/app/discover#/
[00:00:52]               │ debg TestSubjects.find(kibanaChrome)
[00:00:52]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:52]               │ debg ... sleep(501) start
[00:00:53]               │ debg browser[INFO] http://localhost:61221/36800/bundles/core/core.entry.js 26:218333 "Detected an unhandled Promise rejection.
[00:00:53]               │      Error: Saved field \"@timestamp\" is invalid for use with the \"Date Histogram\" aggregation. Please select a new field."
[00:00:53]               │ERROR browser[SEVERE] http://localhost:61221/36800/bundles/plugin/data/data.plugin.js 5:524969 Uncaught Error: Saved field "@timestamp" is invalid for use with t…istogram" aggregation. Please select a new field.
[00:00:53]               │ debg ... sleep(501) end
[00:00:53]               │ debg in navigateTo url = http://localhost:61221/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-18T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:00:53]               │ debg --- retry.try error: URL changed, waiting for it to settle
[00:00:53]               │ debg ... sleep(501) start
[00:00:54]               │ debg ... sleep(501) end
[00:00:54]               │ debg in navigateTo url = http://localhost:61221/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-18T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:00:54]               │ debg TestSubjects.exists(statusPageContainer)
[00:00:54]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:00:57]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:00:57]               │ debg TestSubjects.click(field-agent)
[00:00:57]               │ debg Find.clickByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:00:57]               │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:01:07]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:01:07]               │      Wait timed out after 10010ms
[00:01:08]               │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:01:18]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:01:18]               │      Wait timed out after 10012ms
[00:01:18]               │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:01:28]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:01:28]               │      Wait timed out after 10023ms
[00:01:29]               │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:01:39]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:01:39]               │      Wait timed out after 10037ms
[00:01:39]               │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:01:49]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:01:49]               │      Wait timed out after 10052ms
[00:01:50]               │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:02:00]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:02:00]               │      Wait timed out after 10008ms
[00:02:00]               │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:02:10]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:02:10]               │      Wait timed out after 10052ms
[00:02:11]               │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:02:21]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:02:21]               │      Wait timed out after 10035ms
[00:02:21]               │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:02:31]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:02:31]               │      Wait timed out after 10047ms
[00:02:32]               │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:02:42]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:02:42]               │      Wait timed out after 10014ms
[00:02:42]               │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:02:52]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:02:52]               │      Wait timed out after 10071ms
[00:02:53]               │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:03:03]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:03:03]               │      Wait timed out after 10029ms
[00:03:03]               │ info Taking screenshot "/dev/shm/workspace/parallel/22/kibana/test/functional/screenshots/failure/context app discover - context - back navigation _before all_ hook.png"
[00:03:04]               │ info Current URL is: http://localhost:61221/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-18T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:03:04]               │ info Saving page source to: /dev/shm/workspace/parallel/22/kibana/test/functional/failure_debug/html/context app discover - context - back navigation _before all_ hook.html
[00:03:04]               └- ✖ fail: context app discover - context - back navigation "before all" hook for "should go back after loading"
[00:03:04]               │      Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
[00:03:04]               │ Wait timed out after 10029ms
[00:03:04]               │     at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:03:04]               │     at process._tickCallback (internal/process/next_tick.js:68:7)
[00:03:04]               │       at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
[00:03:04]               │       at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)
[00:03:04]               │ 
[00:03:04]               │

Stack Trace

Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="field-agent"])
Wait timed out after 10029ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)

Metrics [docs]

async chunks size

id	value	diff	baseline
`canvas`	1.5MB	+190.4KB	1.4MB

distributable file count

id	value	diff	baseline
`default`	45839	+9	45830

page load bundle size

id	value	diff	baseline
`canvas`	1.0MB	-186.3KB	1.2MB

History

💔 Build #77410 failed f796204
💚 Build #77389 succeeded c28c2b0
💔 Build #77222 failed 1000134

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

crob611 · 2020-10-01T13:09:57Z

@poffdeluxe Good Questions.

No, the import will only be loaded once.
It appears that everything still work fine in the shareable runtime. I'm not sure why. It imports the flot renderers but they don't get split out into separate chunks. Maybe it's webpack build is setup that way? Anyways all appears to work as expected.

…astic#78542) * Move Handlebars and Flot dependencies out of main bundle * Fix unit test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

kibanamachine · 2020-10-05T13:14:39Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2020-10-06T13:24:39Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

…8542) (#79115) * Move Handlebars and Flot dependencies out of main bundle * Fix unit test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Corey Robertson added 2 commits September 25, 2020 12:56

Move Handlebars and Flot dependencies out of main bundle

1000134

Fix unit test

c28c2b0

Merge branch 'master' into canvas-move-dependency

f796204

crob611 marked this pull request as ready for review September 28, 2020 14:12

crob611 requested a review from a team as a code owner September 28, 2020 14:12

poffdeluxe approved these changes Sep 28, 2020

View reviewed changes

Merge branch 'master' into canvas-move-dependency

08785d5

crob611 merged commit 9e5bf0f into elastic:master Oct 1, 2020

crob611 mentioned this pull request Oct 1, 2020

[7.x] [Canvas] Move Handlebars and Flot dependencies out of main bundle (#78542) #79115

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 5, 2020

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 6, 2020

crob611 mentioned this pull request Dec 2, 2020

[Canvas] Reduce Entry Bundle Size #84793

Closed

cqliu1 mentioned this pull request Apr 6, 2023

[canvas] Reduce page load bundle to under 100kB #95857

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Canvas] Move Handlebars and Flot dependencies out of main bundle #78542

[Canvas] Move Handlebars and Flot dependencies out of main bundle #78542

crob611 commented Sep 25, 2020

crob611 commented Sep 28, 2020

elasticmachine commented Sep 28, 2020

poffdeluxe left a comment •

edited

Loading

crob611 commented Sep 30, 2020

kibanamachine commented Sep 30, 2020

Standard Out

Stack Trace

crob611 commented Oct 1, 2020

kibanamachine commented Oct 5, 2020

kibanamachine commented Oct 6, 2020

[Canvas] Move Handlebars and Flot dependencies out of main bundle #78542

[Canvas] Move Handlebars and Flot dependencies out of main bundle #78542

Conversation

crob611 commented Sep 25, 2020

Summary

crob611 commented Sep 28, 2020

elasticmachine commented Sep 28, 2020

poffdeluxe left a comment • edited Loading

Choose a reason for hiding this comment

crob611 commented Sep 30, 2020

kibanamachine commented Sep 30, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

async chunks size

distributable file count

page load bundle size

History

crob611 commented Oct 1, 2020

kibanamachine commented Oct 5, 2020

kibanamachine commented Oct 6, 2020

poffdeluxe left a comment •

edited

Loading