Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fixes url timeline flaky test #78556

Merged
merged 3 commits into from
Sep 29, 2020
Merged

[Security Solution] Fixes url timeline flaky test #78556

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ae6c04
fixes url timeline flaky test
MadameSheema Sep 26, 2020
f00ff62
fixes type check issue
MadameSheema Sep 26, 2020
9a32f34
Merge branch 'master' into fixes-timeline-flaky-test
elasticmachine Sep 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 11 additions & 20 deletions x-pack/plugins/security_solution/cypress/integration/url_state.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
import { HOSTS_NAMES } from '../screens/hosts/all_hosts';
import { ANOMALIES_TAB } from '../screens/hosts/main';
import { BREADCRUMBS, HOSTS, KQL_INPUT, NETWORK } from '../screens/security_header';
import { SERVER_SIDE_EVENT_COUNT, TIMELINE_TITLE } from '../screens/timeline';
import { TIMELINE_TITLE } from '../screens/timeline';

import { loginAndWaitForPage, loginAndWaitForPageWithoutDateRange } from '../tasks/login';
import {
Expand All @@ -32,16 +32,18 @@ import { waitForIpsTableToBeLoaded } from '../tasks/network/flows';
import { clearSearchBar, kqlSearch, navigateFromHeaderTo } from '../tasks/security_header';
import { openTimelineUsingToggle } from '../tasks/security_main';
import {
addDescriptionToTimeline,
addNameToTimeline,
closeTimeline,
executeTimelineKQL,
populateTimeline,
waitForTimelineChanges,
} from '../tasks/timeline';

import { HOSTS_URL } from '../urls/navigation';
import { ABSOLUTE_DATE_RANGE } from '../urls/state';

import { timeline } from '../objects/timeline';
import { TIMELINE } from '../screens/create_new_case';

const ABSOLUTE_DATE = {
endTime: '2019-08-01T20:33:29.186Z',
endTimeTimeline: '2019-08-02T21:03:29.186Z',
Expand All @@ -51,8 +53,7 @@ const ABSOLUTE_DATE = {
startTimeTimeline: '2019-08-02T20:03:29.186Z',
};

// FLAKY: https://github.com/elastic/kibana/issues/61612
describe.skip('url state', () => {
describe('url state', () => {
it('sets the global start and end dates from the url', () => {
loginAndWaitForPageWithoutDateRange(ABSOLUTE_DATE_RANGE.url);
cy.get(DATE_PICKER_START_DATE_POPOVER_BUTTON).should(
Expand Down Expand Up @@ -222,23 +223,12 @@ describe.skip('url state', () => {
it('sets and reads the url state for timeline by id', () => {
loginAndWaitForPage(HOSTS_URL);
openTimelineUsingToggle();
executeTimelineKQL('host.name: *');

cy.get(SERVER_SIDE_EVENT_COUNT)
.invoke('text')
.then((strCount) => {
const intCount = +strCount;
cy.wrap(intCount).should('be.above', 0);
});
populateTimeline();

cy.server();
cy.route('PATCH', '**/api/timeline').as('timeline');

const timelineName = 'Security';
const timelineDescription = 'This is the best timeline of the world';
addNameToTimeline(timelineName);
waitForTimelineChanges();
addDescriptionToTimeline(timelineDescription);
addNameToTimeline(timeline.title);
waitForTimelineChanges();

cy.wait('@timeline').then((response) => {
Expand All @@ -249,9 +239,10 @@ describe.skip('url state', () => {
cy.visit('/app/home');
cy.visit(`/app/security/timelines?timeline=(id:'${timelineId}',isOpen:!t)`);
cy.get(DATE_PICKER_APPLY_BUTTON_TIMELINE).should('exist');
cy.get(DATE_PICKER_APPLY_BUTTON_TIMELINE).invoke('text').should('not.equal', 'Updating');
cy.get(DATE_PICKER_APPLY_BUTTON_TIMELINE).should('not.have.text', 'Updating');
cy.get(TIMELINE).should('be.visible');
cy.get(TIMELINE_TITLE).should('be.visible');
cy.get(TIMELINE_TITLE).should('have.attr', 'value', timelineName);
cy.get(TIMELINE_TITLE).should('have.attr', 'value', timeline.title);
});
});
});