Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Fixed dead links #78696

Merged
merged 2 commits into from
Oct 30, 2020
Merged

[Docs] Fixed dead links #78696

merged 2 commits into from
Oct 30, 2020

Conversation

ba0708
Copy link
Contributor

@ba0708 ba0708 commented Sep 28, 2020

Fixed incorrect links to images (404).

@ba0708
Fixed dead links
b6dfbc5 
Fixed links to 404 page.
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ba0708 ba0708 changed the title Fixed dead links [Docs] Fixed dead links Sep 28, 2020
@lukeelmers lukeelmers added docs Team:Monitoring Stack Monitoring team labels Oct 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline
Copy link
Contributor

Hi @ba0708!

Thank you for your contribution!

Do you mind sharing which page you visited to discover these broken links?

This page seems fine to me: https://www.elastic.co/guide/en/kibana/master/beats-page.html

@ba0708
Copy link
Contributor Author

ba0708 commented Oct 22, 2020

@chrisronline It's exactly that page. The issue is not displaying the images; it's that if you click on them, you are sent to a 404 page. The links work on a handful of other pages that I checked, but not this one. 🙂

@chrisronline
Copy link
Contributor

@ba0708 Thank you for that clarification! Great catch!

@chrisronline
Copy link
Contributor

Jenkin, test this

@jbudz
Copy link
Member

jbudz commented Oct 29, 2020

@elasticmachine merge upstream

@chrisronline
Copy link
Contributor

Jenkin, test this

@chrisronline chrisronline merged commit 2aeeb6e into elastic:master Oct 30, 2020
@chrisronline
Copy link
Contributor

Thanks so much for your contribution @ba0708!

@ba0708 ba0708 deleted the patch-1 branch October 30, 2020 11:14
@ba0708
Copy link
Contributor Author

ba0708 commented Oct 30, 2020

My pleasure, @chrisronline! 🙂

@chrisronline chrisronline mentioned this pull request Oct 30, 2020
Merged
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Oct 30, 2020
@ba0708 @kibanamachine @chrisronline
Fixed dead links (elastic#78696)
0b7cea8 
Fixed links to 404 page.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Oct 30, 2020
@ba0708 @kibanamachine @chrisronline
Fixed dead links (elastic#78696)
45cf008 
Fixed links to 404 page.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@chrisronline chrisronline mentioned this pull request Oct 30, 2020
Merged
chrisronline added a commit that referenced this pull request Oct 30, 2020
@chrisronline @ba0708 @kibanamachine
Fixed dead links (#78696) (#82130)
3e27099 
Fixed links to 404 page.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Bo Andersen <ba0708@icloud.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline added a commit that referenced this pull request Oct 30, 2020
@chrisronline @ba0708 @kibanamachine
Fixed dead links (#78696) (#82129)
aab4657 
Fixed links to 404 page.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Bo Andersen <ba0708@icloud.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 30, 2020
@gmmorris
Merge branch 'master' into alerts/convert-to-tm-intervals
1929b5d 
* master: (71 commits)
  [Chrome] Extension to append an element to the last breadcrumb (elastic#82015)
  [Monitoring] Thread pool rejections alert (elastic#79433)
  [Actions] Fix actionType type on registerType function (elastic#82125)
  [Security Solution] Modal for saving timeline (elastic#81802)
  add tests for index pattern switching (elastic#81987)
  TS project references for share plugin (elastic#82051)
  [Graph] Fix problem with duplicate ids (elastic#82109)
  skip 'returns a single bucket if array has 1'.  related elastic#81460
  Add a link to documentation in the alerts and actions management UI (elastic#81909)
  [Fleet] fix duplicate ingest pipeline refs (elastic#82078)
  Context menu trigger for URL Drilldown (elastic#81158)
  SO management: fix legacy import index pattern selection being reset when switching page (elastic#81621)
  Fixed dead links (elastic#78696)
  [Search] Add "restore" to session service (elastic#81924)
  fix Lens heading structure (elastic#81752)
  [ML] Data Frame Analytics: Fix feature importance cell value and decision path chart (elastic#82011)
  Remove legacy app arch items from codeowners. (elastic#82084)
  [TSVB] Renamed 'positive rate' to 'counter rate' (elastic#80939)
  Expressions/migrations2 (elastic#81281)
  [Telemetry] [Schema] remove number type and support all es number types (elastic#81774)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisronline chrisronline chrisronline approved these changes

Assignees
No one assigned
Labels
💝community docs release_note:fix Team:Monitoring Stack Monitoring team v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ba0708 @kibanamachine @elasticmachine @chrisronline @jbudz @lukeelmers