Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Resolver] New mock with cursor #78863

Merged
merged 5 commits into from
Sep 30, 2020
Merged

[Security Solution][Resolver] New mock with cursor #78863

merged 5 commits into from
Sep 30, 2020

Conversation

bkimmel
Copy link
Contributor

@bkimmel bkimmel commented Sep 29, 2020 •
edited
Loading

Summary

This PR adds a mock with a Data Access Layer that imitates the sequence for fetching related events behind the after cursor

For maintainers

@bkimmel
Copy link
Contributor Author

bkimmel commented Sep 30, 2020

@elasticmachine merge upstream

@bkimmel bkimmel changed the title New mock with cursor [Security Solution][Resolver] New mock with cursor Sep 30, 2020
@bkimmel bkimmel added v8.0.0 v7.10.0 Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Data Visibility Team managing the endpoint resolver labels Sep 30, 2020
@bkimmel
Copy link
Contributor Author

bkimmel commented Sep 30, 2020

@elasticmachine merge upstream

@bkimmel bkimmel marked this pull request as ready for review September 30, 2020 16:34
@bkimmel bkimmel requested review from a team as code owners September 30, 2020 16:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Resolver)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id value diff baseline
securitySolution 10.2MB +102.0B 10.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bkimmel bkimmel merged commit 6f1a158 into elastic:master Sep 30, 2020
@bkimmel bkimmel deleted the resolver/new-mock-with-cursor branch September 30, 2020 19:23
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 30, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into override-anom…
1587918 
…aly-detection-partition-field

* 'master' of github.com:elastic/kibana: (37 commits)
  Fixes for the Ticket 78375 (elastic#79004)
  [Security] Alert Telemetry for the Security app (elastic#77200)
  [Search bar] Remove duplicate `popoverProps` (elastic#79025)
  [Security Solution][Detections] Add rule overrides for single event EQL rules (elastic#78876)
  [SECURITY_SOLUTION][ENDPOINT] Improve Endpoint Host data generator to also integrate with Ingest (elastic#74305)
  remove file accidentally checked in (elastic#79005)
  [ML] DF Analytics creation wizard: replace select input with job type cards with icons (elastic#78872)
  [Design] A couple fixes for 7.10 (elastic#78801)
  Fix KQL autocomplete value suggestions (elastic#78676)
  [Security Solution][Resolver] New mock with cursor (elastic#78863)
  Embeddables: basic documentation (elastic#78900)
  [security solution] only import beat_schema when needed (elastic#78708)
  [Reporting] API Integration tests: fix flaky tests for Spaces CSV formatting (elastic#78849)
  [Actions] Adds a "Test Connector" button on the Connectors List to make discovery of the Test tab easier (elastic#78746)
  [Discover] Fix functional time picker test permissions (elastic#78564)
  [ML] Fixing module datafeed overrides (elastic#78925)
  Adds some missing licenses to the CSV export (elastic#78719)
  [dev/cli] ensure plugins/ and all watch source dirs exist (elastic#78973)
  [Lens] Stop using scripted metric to collect telemetry (elastic#78687)
  [Lens] fix wrong message in fields accordion (elastic#78924)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 2, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78863 or prevent reminders by adding the backport:skip label.

michaelolo24 pushed a commit to michaelolo24/kibana that referenced this pull request Oct 2, 2020
@bkimmel @elasticmachine @michaelolo24
[Security Solution][Resolver] New mock with cursor (elastic#78863)
7d8754b 
* New mock with cursor

* include next cursor

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@michaelolo24 michaelolo24 mentioned this pull request Oct 2, 2020
Merged
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 5, 2020
bkimmel added a commit that referenced this pull request Oct 5, 2020
@michaelolo24 @bkimmel
@elasticmachine @kibanamachine
[Security Solution][Resolver] New mock with cursor (#78863) (#79356)
a846cf7 
* New mock with cursor

* include next cursor

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Brent Kimmel <bkimmel@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees
No one assigned
Labels
Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Data Visibility Team managing the endpoint resolver v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bkimmel @elasticmachine @kibanamachine @michaelolo24 @kqualters-elastic