-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Add core web vitals in obsv homepage #78976
Conversation
x-pack/plugins/observability/public/pages/overview/loading_observability.tsx
Outdated
Show resolved
Hide resolved
@shahzad31 maybe you've already done it, but I think you want to add an empty state for the |
|
||
interface UXHasDataResponse { | ||
hasData: boolean; | ||
serviceName: string | number | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about this, I feel hasData
has been given way more responsibility than only checking if there is any data available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with separation of hooks this will improve
Pinging @elastic/uptime (Team:uptime) |
Pinging @elastic/apm-ui (Team:apm) |
@shahzad31 @formgeist I'm not sure if you want to add an empty state section for the UX too like: |
@cauemarcondes @shahzad31 Yes, good call - I think we should promote here too. The button link would go to the RUM agent setup instructions. I'll try and find some copy that we can use for the message. |
@formgeist maybe we should consider adding a new app in the |
@cauemarcondes Perhaps, but I think this is also a silent release, so I'll follow up with the UX PMs to see how they want to promote it. |
@cauemarcondes added empty state, i am not sure, what happened there, i am adding this second time, i guess i deleted that while i was deleting loading improvement refactor :) |
x-pack/plugins/observability/public/components/shared/core_web_vitals/web_core_vitals_title.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the refactorings 🎉
I reckon we need to make the "view in app" link read the service name value so we link to the right service within the app. I think right now it doesn't pass anything into the URL params. @shahzad31 is it selecting the app with the most traffic in the UX app as well? Hence why I think it's important that you don't land on another service than is specified in the overview page. |
@formgeist I think i will have to check, but i think it make sense to align this in UX and make sure it selects the service with most traffic, i will do the change in UX app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from design - only need to make the view in app link use the service name
The UX app will find the service with the most traffic as default selected service as well, so we don't need to specify it in the URL for "view in app". |
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
Summary
Fixes: #78974
Added core vital view in observability homepage, basically moved component from UX app and reused api.