[Fleet] Fix agent policy change action migration #79046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
bug
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jen-huang
changed the title
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Oct 1, 2020
* Fix agent policy change action migration for encrypted `data` property * Parse & re-stringify `config`->`policy` data
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Oct 1, 2020
jen-huang
added a commit
that referenced
this pull request
Oct 1, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Oct 1, 2020
…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (76 commits) Fix z-index of KQL Suggestions dropdown (elastic#79184) [babel] remove unused/unneeded babel plugins (elastic#79173) [Search] Fix timeout upgrade link (elastic#79045) Always Show Embeddable Panel Header in Edit Mode (elastic#79152) [Ingest]: add more test for transform index (elastic#79154) [ML] DF Analytics: Collapsable sections on results pages (elastic#76641) [Fleet] Fix agent policy change action migration (elastic#79046) [Ingest Manager] Match package spec `dataset`->`data_stream` and `config_templates`->`policy_templates` renaming (elastic#78699) Revert "[Metrics UI] Add ability to override datafeeds and job config for partition field (elastic#78875)" [ML] Update transform cloning to include description and new fields (elastic#78364) chore(NA): remove non existing plugin paths from case api integration tests (elastic#79127) [Ingest Manager] Ensure we trigger agent policy updated event when we bump revision. (elastic#78836) [Metrics UI] Display No Data context.values as [NO DATA] (elastic#78038) [Monitoring] Missing data alert (elastic#78208) [Lens] Fix embeddable title and description for reporting and dashboard tooltip (elastic#78767) [Lens] Consistent Drag and Drop styles (elastic#78674) [ML] Model management UI fixes and enhancements (elastic#79072) [Metrics UI] Add ability to override datafeeds and job config for partition field (elastic#78875) [Security Solution]Fix basepath used by endpoint telemetry tests (elastic#79027) update rum agent version which contains longtasks (elastic#79105) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #78221. In that PR, saved object migrations was added for agent policy change actions to support the renamed fields, but
datafield is encrypted so the migration did not work fully.This PR fixes that by using EncryptedSavedObject plugin's
createMigration()so that the encrypteddatafield can properly be read, parsed, and restructured.I tested this by comparing the response of the agent checkin endpoint (which returns decrypted unacknowledged actions) between
7.9branch and this PR branch. I seeded the data using 7.9 and the migrations kicked in properly after switching versions:POST /api/ingest_manager/fleet/agents/2fddde39-5591-49d3-a8c9-0b80eeaf4a4d/checkin { "action": "checkin", "actions": [ { "agent_id": "2fddde39-5591-49d3-a8c9-0b80eeaf4a4d", + "type": "POLICY_CHANGE", - "type": "CONFIG_CHANGE", "data": { + "policy": { - "config": { "id": "c8718610-0367-11eb-a0f4-85d0971da8ba", "outputs": { ...