Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vega] Maps still experimental #79114

Merged
merged 4 commits into from
Oct 5, 2020
Merged

[Vega] Maps still experimental #79114

merged 4 commits into from
Oct 5, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Oct 1, 2020 •
edited
Loading

Closes: #78267

Summary

Adding an experimental warning when user works on a vega map

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp
Copy link
Contributor Author

alexwizp commented Oct 1, 2020

@stratoula @timroes I have one concern around that task. In vega vis we cannot understand from which place visualization was opened (from dashboard or from vis_editor). It's a bad thing cause by default that message will be shown on dashboard too.

image

Yes, user can hide it using the hideWarnings configuration field but anyway not sure that we want to see it by default.

image

Any ideas?

@stratoula
Copy link
Contributor

@alexwizp I agree, this is not very good. Have you tried to add the Callout outside the visualization container?

alexwizp
alexwizp commented Oct 2, 2020
View reviewed changes
src/plugins/visualizations/public/vis_types/base_vis_type.ts Outdated
@@ -44,7 +44,7 @@ interface CommonBaseVisTypeOptions {
useCustomNoDataScreen?: boolean;
inspectorAdapters?: Adapters | (() => Adapters);
isDeprecated?: boolean;
getDeprecationMessage?: (vis: Vis) => ReactElement<{}>;
getInfoMessage?: (vis: Vis) => ReactElement<{}>;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timroes @stratoula @sulemanof Probably we can use getDeprecationMessage to archive out goal.
But name should be more generic.

One more point if we decide to go with it, in this case we should parse spec twice =( But probably it's not a problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this approach 🙂

@alexwizp
Copy link
Contributor Author

alexwizp commented Oct 2, 2020

@elasticmachine merge upstream

@alexwizp alexwizp self-assigned this Oct 2, 2020
@alexwizp alexwizp added v7.10.0 v8.0.0 Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes labels Oct 2, 2020
@alexwizp alexwizp marked this pull request as ready for review October 2, 2020 13:28
@alexwizp alexwizp requested a review from a team October 2, 2020 13:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula
stratoula approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it locally, it works as expected. Code LGTM

sulemanof
sulemanof reviewed Oct 2, 2020
View reviewed changes
src/plugins/vis_type_vega/public/components/experimental_map_vis_info.tsx Outdated
);

return (
<I18nProvider>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provider is extra here.

sulemanof
sulemanof approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp
Copy link
Contributor Author

alexwizp commented Oct 5, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
visTypeVega 79 80 +1

async chunks size

id before after diff
visTypeVega 1.4MB 1.4MB +1.0B
visualize 271.4KB 271.4KB -7.0B
total -6.0B

page load bundle size

id before after diff
regionMap 49.9KB 49.9KB -7.0B
tileMap 49.1KB 49.1KB -7.0B
visTypeVega 134.0KB 135.3KB +1.4KB
visualizations 272.2KB 272.2KB -21.0B
total +1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 4db2203 into elastic:master Oct 5, 2020
@alexwizp alexwizp mentioned this pull request Oct 5, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Oct 5, 2020
@alexwizp @kibanamachine
[Vega] Maps still experimental (elastic#79114)
096965f 
* [Vega] Maps still experimental

* fix TS issues

* cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp added a commit that referenced this pull request Oct 5, 2020
@alexwizp @kibanamachine
[Vega] Maps still experimental (#79114) (#79423)
1fac129 
* [Vega] Maps still experimental

* fix TS issues

* cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulemanof sulemanof sulemanof approved these changes

@stratoula stratoula stratoula approved these changes

@DianaDerevyankina DianaDerevyankina Awaiting requested review from DianaDerevyankina

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

@timroes timroes Awaiting requested review from timroes

Assignees

@alexwizp alexwizp

Labels
Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Vega] Maps still experimental
5 participants
@alexwizp @stratoula @elasticmachine @kibanamachine @sulemanof