Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Timelion visualization renderer (#78540) #79124

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

sulemanof
Copy link
Contributor

Backports the following commits to 7.x:

* Update styles

* Implement toExpressionAst fn

* Implement renderer

* Update unit tests

* Add unit tests

* Update types

* Remove unused vars

* Fix types

* Update types

* Show error message when no data

* Update ExpressionRenderDefinition api

* Update renderer when there is no data

* Make options component lazy

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	docs/development/plugins/expressions/public/kibana-plugin-plugins-expressions-public.expressionrenderdefinition.displayname.md
#	docs/development/plugins/expressions/server/kibana-plugin-plugins-expressions-server.expressionrenderdefinition.displayname.md
#	src/plugins/expressions/public/public.api.md
#	src/plugins/expressions/server/server.api.md
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
timelion 455.5KB 463.1KB +7.6KB
visTypeTimelion 0.0B 154.3KB +154.3KB
total +161.9KB

distributable file count

id before after diff
default 47580 47586 +6
oss 28291 28297 +6

page load bundle size

id before after diff
visTypeTimelion 183.4KB 36.1KB -147.3KB
visualizations 272.6KB 272.4KB -210.0B
total -147.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit 1c7a987 into elastic:7.x Oct 1, 2020
@sulemanof sulemanof deleted the backport/7.x/pr-78540 branch October 1, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants