Add logarithmic scale for bar charts #7939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good, can we double check log and sqrt work for stacked bar charts? #3437 implies this might have complications. |
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
|
@thomasneirynck in the future it would be great if the error refactoring here could be done in a separate PR |
|
LGTM |
|
jenkins, test this |
The bar chart visualization already seemed to support it, but the UI-form was not included in the template. Also applied some linter corrections.
Still allow non-linear scaling for side-by-side displays of columns. Included small refactor to reduce some of the error handling footprint.
thomasneirynck
force-pushed
the
fix/5708
branch
from
5dced00
to
f606dd0
Compare
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
This was referenced Aug 9, 2016
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Add logarithmic scale for bar charts Former-commit-id: 0c9e30c
cee-chen
added a commit
that referenced
this pull request
Aug 5, 2024
`v95.5.0` ⏩ `v95.6.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.6.0`](https://github.com/elastic/eui/releases/v95.6.0) - Updated `EuiIcon` with a new `crossInCircle` glyph ([#7924](elastic/eui#7924)) **Bug fixes** - Fixed `EuiEmptyPrompt` to correctly collapse and expand responsively when used with custom breakpoints larger than the default `xl` breakpoint ([#7935](elastic/eui#7935)) **Accessibility** - Improved the experience of `EuiModal` by ensuring nested `EuiPopover` closes on `Escape` keypress instead of the modal ([#7939](elastic/eui#7939)) **CSS-in-JS conversions** - Converted `EuiDatePicker` to Emotion ([#7937](elastic/eui#7937)) - Removed `$euiDatePickerCalendarWidth` - Removed `$euiDatePickerPadding` - Removed `$euiDatePickerGap` - Removed `$euiDatePickerCalendarColumns` - Removed `$euiDatePickerButtonSize` - Removed `$euiDatePickerMinControlWidth` - Removed `$euiDatePickerMaxControlWidth` - Removed `@mixin datePickerCaret` - Removed `@mixin datePickerArrow`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #5708.
It only adds the drop down selection. Because this UI-snippet binds to the y-axis component, the new scaling method is applied automatically.
Also removed some unused variables due to linting.