Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest pipelines] Fix duplicate tab states #79501

Merged
merged 2 commits into from
Oct 6, 2020
Merged

[Ingest pipelines] Fix duplicate tab states #79501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a43a3c
remove duplicate tab states
alisonelizabeth Oct 5, 2020
c180560
Merge branch 'master' into bugfix/ingest_pipelines/active_tab
kibanamachine Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...line_processors_editor/components/test_pipeline/documents_dropdown/documents_dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const i18nTexts = {
defaultMessage: 'Documents:',
}
),
addDocumentsButtonLabel: i18n.translate(
editDocumentsButtonLabel: i18n.translate(
'xpack.ingestPipelines.pipelineEditor.testPipeline.documentsDropdown.editDocumentsButtonLabel',
{
defaultMessage: 'Edit documents',
Expand Down Expand Up @@ -124,7 +124,7 @@ export const DocumentsDropdown: FunctionComponent<Props> = ({
}}
data-test-subj="editDocumentsButton"
>
{i18nTexts.addDocumentsButtonLabel}
{i18nTexts.editDocumentsButtonLabel}
</EuiButton>
</EuiPopoverFooter>
</EuiPopover>
Expand Down
1 change: 1 addition & 0 deletions .../components/pipeline_processors_editor/components/test_pipeline/test_pipeline_actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export const TestPipelineActions: FunctionComponent = () => {
{openTestPipelineFlyout && (
<TestPipelineFlyout
activeTab={activeFlyoutTab}
setActiveTab={setActiveFlyoutTab}
processors={{
processors: processors.state.processors,
onFailure: processors.state.onFailure,
Expand Down
10 changes: 5 additions & 5 deletions ...ts/pipeline_processors_editor/components/test_pipeline/test_pipeline_flyout.container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { TestPipelineFlyoutTab } from './test_pipeline_tabs';

export interface Props {
activeTab: TestPipelineFlyoutTab;
setActiveTab: (tab: TestPipelineFlyoutTab) => void;
onClose: () => void;
processors: DeserializeResult;
}
Expand All @@ -35,6 +36,7 @@ export interface TestPipelineFlyoutForm {
export const TestPipelineFlyout: React.FunctionComponent<Props> = ({
onClose,
activeTab,
setActiveTab,
processors,
}) => {
const { services } = useKibana();
Expand All @@ -56,8 +58,6 @@ export const TestPipelineFlyout: React.FunctionComponent<Props> = ({
},
});

const [selectedTab, setSelectedTab] = useState<TestPipelineFlyoutTab>(activeTab);

const [isRunningTest, setIsRunningTest] = useState<boolean>(false);
const [testingError, setTestingError] = useState<any>(null);
const [testOutput, setTestOutput] = useState<any>(undefined);
Expand Down Expand Up @@ -155,7 +155,7 @@ export const TestPipelineFlyout: React.FunctionComponent<Props> = ({
});

if (isSuccessful) {
setSelectedTab('output');
setActiveTab('output');
}
};

Expand Down Expand Up @@ -184,8 +184,8 @@ export const TestPipelineFlyout: React.FunctionComponent<Props> = ({
testOutput={testOutput}
form={form}
validateAndTestPipeline={validateAndTestPipeline}
selectedTab={selectedTab}
setSelectedTab={setSelectedTab}
selectedTab={activeTab}
setSelectedTab={setActiveTab}
testingError={testingError}
onClose={onClose}
/>
Expand Down