[ML] avoid full page reload for links following CSV import #79539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
:ml
v8.0.0
Feature:File and Index Data Viz
|
Pinging @elastic/ml-ui (:ml) |
nreese
commented
Oct 5, 2020
|
|
||
| let discoverUrlGenerator; | ||
| try { | ||
| discoverUrlGenerator = getUrlGenerator(DISCOVER_APP_URL_GENERATOR); |
There was a problem hiding this comment.
getUrlGenerator throws when the id is not found. Adding code to avoid unhandled errors
nreese
commented
Oct 5, 2020
| if (!discoverUrlGenerator) { | ||
| return; | ||
| } | ||
| const discoverUrl = await discoverUrlGenerator.createUrl(state); | ||
| if (!unmounted) { |
There was a problem hiding this comment.
Need to check for unmounted after await, not before
qn895
reviewed
Oct 5, 2020
| @@ -142,9 +148,26 @@ export const ResultsLinks: FC<Props> = ({ | |||
| } | |||
| } | |||
|
|
|||
| function openInDiscover(e: React.MouseEvent<HTMLButtonElement>) { | |||
| e.preventDefault(); | |||
| getApplication().navigateToUrl(discoverLink); | |||
There was a problem hiding this comment.
Should this fallback to something else instead of '' if getUrlGenerator(DISCOVER_APP_URL_GENERATOR) throws an error?
There was a problem hiding this comment.
Button is not visible if discoverLink is not provided so onClick could not be called.
...s/ml/public/application/datavisualizer/file_based/components/results_links/results_links.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 6, 2020
…9539) * [ML] avoid full page reload for links following CSV import * cleanup * review feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Oct 6, 2020
…79698) * [ML] avoid full page reload for links following CSV import * cleanup * review feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of linking to Discover, Index management, and Index pattern management after a CSV import causes a full page reload. Clicking the buttons below should not cause a full page reload.
This PR updates the implementation to used navigateToApp and navigateToUrl to avoid the full page reload.