Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fixes EQL flaky test #79695

Merged
merged 2 commits into from
Oct 7, 2020
Merged

[Security Solution] Fixes EQL flaky test #79695

merged 2 commits into from
Oct 7, 2020

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Oct 6, 2020 •
edited
Loading

Summary

Fixes skipped EQL flaky tests: #79522

@MadameSheema MadameSheema requested review from a team as code owners October 6, 2020 15:56
@MadameSheema MadameSheema changed the title [Security Solution] Fixes flaky test [Security Solution] Fixes EQL flaky test Oct 6, 2020
@MadameSheema MadameSheema self-assigned this Oct 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@MadameSheema MadameSheema added the release_note:skip Skip the PR/issue when compiling release notes label Oct 6, 2020
rylnd
rylnd approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, conveying a conversation with @MadameSheema here: this test was failing due to shared global state (elasticsearch): both tests create rules, and both tests assert that there's only one rule. It seems as though the test passed initially because it was run independently, while subsequent builds grouped them together.

Regardless, the quick fix here is to rebuild our indexes on each test, thereby removing (or at least minimizing) the state shared between tests.

@rylnd
Copy link
Contributor

rylnd commented Oct 6, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema merged commit edce4eb into elastic:master Oct 7, 2020
@MadameSheema MadameSheema deleted the fix/flaky-eql branch October 7, 2020 09:09
@MadameSheema MadameSheema mentioned this pull request Oct 7, 2020
Merged
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Oct 7, 2020
@MadameSheema
fixes flaky test (elastic#79695)
9d60526 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_eql.spec.ts
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 9, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 12, 2020
MadameSheema added a commit that referenced this pull request Oct 12, 2020
@MadameSheema @kibanamachine
[7.x] fixes flaky test (#79695) (#79829)
29426f5 
* fixes flaky test (#79695)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_eql.spec.ts

* fixes typecheck issue

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

Assignees

@MadameSheema MadameSheema

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MadameSheema @elasticmachine @rylnd @kibanamachine @MindyRS