-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix can't edit a scripted field with special char #79842
Merged
Dosant
merged 1 commit into
elastic:master
from
Dosant:bug/edit-scripted-field-with-special-char
Oct 8, 2020
Merged
fix can't edit a scripted field with special char #79842
Dosant
merged 1 commit into
elastic:master
from
Dosant:bug/edit-scripted-field-with-special-char
Oct 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
Team:AppArch
v7.11.0
v8.0.0
release_note:fix
Feature:Data Views
Data Views code and UI - index patterns before 8.0
release_note:skip
Skip the PR/issue when compiling release notes
bug
Fixes for quality problems that affect the customer experience
labels
Oct 7, 2020
Pinging @elastic/kibana-app-arch (Team:AppArch) |
mattkime
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good and work well. IMO, would be good to backport this to 7.10 and 7.9.
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Oct 8, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 8, 2020
* master: (217 commits) Fix dashboard "snapshot share" is not sharing panel state in view mode (elastic#79837) fix can't edit a scripted field with special char (elastic#79842) [ML] clear selection action (elastic#79834) [TSVB] Show tooltip on external pointer events (elastic#77306) Fixes bug where the same index was being passed in (elastic#79949) Adds date time query and return fields for timestamps and overrides (elastic#79911) [Security Solution][Detections] Reverts rules table tag filter to use AND operator (elastic#79920) add the correct class to truncate the names (elastic#79921) [kbn/optimizer] report limits with ci metrics (elastic#78205) [release notes] extract "dev docs" comment too (elastic#79351) Revert "skips test failing promotion (elastic#79777)" (elastic#79904) share tslib across bundles (elastic#79915) remove entire suite as partial skips aren't doing the trick skip flaky suite (elastic#78689) Skip failing suite (elastic#79522) skip flaky suite (elastic#79910) [es/mappings] remove doc_values from text fields (elastic#79869) remove skipped snapshots skip flaky tests (elastic#79891) chore(NA): add missing branches into backportrc configuration file (elastic#79848) ...
Dosant
added a commit
that referenced
this pull request
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Data Views
Data Views code and UI - index patterns before 8.0
Feature:Scripted Fields
Scripted fields features
release_note:fix
release_note:skip
Skip the PR/issue when compiling release notes
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #76076