Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Upgrade mapbox to latest #79934

Merged
merged 3 commits into from
Oct 13, 2020
Merged

[Maps] Upgrade mapbox to latest #79934

merged 3 commits into from
Oct 13, 2020

Conversation

thomasneirynck
Copy link
Contributor

Summary

Upgrades mapbox to 1.12.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@thomasneirynck thomasneirynck added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.11.0 labels Oct 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck added the release_note:skip Skip the PR/issue when compiling release notes label Oct 7, 2020
@thomasneirynck
Copy link
Contributor Author

@elasticmachine merge upstream

@thomasneirynck thomasneirynck mentioned this pull request Oct 8, 2020
Merged
2 tasks
nreese
nreese approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review, tested in chrome

@thomasneirynck
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
maps 3.2MB 3.2MB +1.6KB

miscellaneous assets size

id before after diff
maps 978.6KB 979.3KB +650.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 46a925a into elastic:master Oct 13, 2020
@thomasneirynck thomasneirynck mentioned this pull request Oct 13, 2020
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Oct 13, 2020
@thomasneirynck @kibanamachine
[Maps] Upgrade mapbox (elastic#79934)
c50e46c 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
thomasneirynck added a commit that referenced this pull request Oct 14, 2020
@thomasneirynck @kibanamachine
[Maps] Upgrade mapbox (#79934) (#80414)
189b516 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasneirynck @elasticmachine @kibanamachine @nreese