[kbn/optimizer] add support for --focus option #80436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
mshustov
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
🏆 Thank you, I will update https://github.com/elastic/kibana/blob/2e34eb239fe753eb09a36e199a8af4792cfb2434/src/core/MIGRATION.md#how-to-understand-how-big-the-bundle-size-of-my-plugin-is and move this section to the best-practices folder. FYI @joshdover
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 14, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #65955
Focus the optimizer on a subset of the bundles, including the implicit and explicit dependencies of those bundles. This can substantially reduce the amount of work the optimizer is doing and is ideal for when you're debugging bundle size changes that cause cascading changes which invalidate a lot of bundle (like when you're working on the optimizer itself and all bundles are constantly invalidated).
The format of the
--focusflag is the same as the--filterflag, with the difference being that each bundle which is matched by the--focusflag has its dependencies (and transitive dependencies) built as well.