Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix role mappings test for ESS #80604

Merged
merged 4 commits into from
Oct 15, 2020

Conversation

legrego
Copy link
Member

@legrego legrego commented Oct 15, 2020

Summary

Ensures that no role mappings exist before running the role mappings functional test suite.

Resolves #76163

Cloud test run: https://internal-ci.elastic.co/job/elastic+estf-cloud-kibana-flaky-test-runner/160/

@legrego legrego added v7.10.0 v7.11.0 v7.9.0 v8.0.0 chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Oct 15, 2020
@legrego legrego marked this pull request as ready for review October 15, 2020 16:13
@legrego legrego requested a review from a team as a code owner October 15, 2020 16:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only -- LGTM!

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego merged commit 5dc9122 into elastic:master Oct 15, 2020
@legrego legrego deleted the security/role-mappings-ess-test branch October 15, 2020 18:20
legrego added a commit to legrego/kibana that referenced this pull request Oct 15, 2020
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
legrego added a commit to legrego/kibana that referenced this pull request Oct 15, 2020
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
legrego added a commit that referenced this pull request Oct 16, 2020
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
legrego added a commit that referenced this pull request Oct 16, 2020
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 16, 2020
* master: (115 commits)
  [ML] Transforms/DF Analytics: Fix data grid column sorting. (elastic#80618)
  added brace import to vis editor (elastic#80652)
  Fix error rate sorting in services list (elastic#80764)
  Emit info log when using custom registry URL (elastic#80768)
  [Reporting] Config Schema Validation for rules[N].protocol strings (elastic#80766)
  Add Storybook a11y addon (elastic#80069)
  Fix anomaly alert selection text (elastic#80746)
  [Security Solution] [Maps] Kibana index pattern, comma bug fix (elastic#80208)
  [kbn/optimizer] tweak split chunks options (elastic#80444)
  update template to use the new team label (elastic#80748)
  [Security Solution] Fix the Field dropdown in Timeline data providers resets when scrolled (elastic#80718)
  Adjusts observability alerting perms to require "all" (elastic#79896)
  [Security Solutions][Detection Engine] Fixes pre-packaged rules which contain exception lists to not overwrite user defined lists   (elastic#80592)
  [data.ui] Fix flaky test & lazy loading rendering artifacts. (elastic#80612)
  Licensed feature usage for connectors (elastic#77679)
  [Security Solution] Cypress template creation (elastic#80180)
  [APM] Hide service if only data is from ML (elastic#80145)
  Fix role mappings test for ESS (elastic#80604)
  [Maps] Add support for envelope (elastic#80614)
  [Security Solution] Update button text according to status (elastic#80389)
  ...
legrego added a commit that referenced this pull request Oct 16, 2020
* Fix role mappings test for ESS (#80604)

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* fix types

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.9.0 v7.10.0 v7.11.0 v8.0.0
Projects
None yet
4 participants