Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timelion] Move the local menu to the header #80627

Merged
merged 6 commits into from
Oct 19, 2020

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Oct 15, 2020

Summary

Closes #80620. It moves the timelion menu to the header in order to be aligned with the other plugins.

Screenshot 2020-10-15 at 1 07 21 PM

@stratoula stratoula mentioned this pull request Oct 15, 2020
2 tasks
@stratoula stratoula added Feature:Timelion Timelion app and visualization v7.11.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 15, 2020
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula requested a review from cchaos October 15, 2020 14:00
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot LGTM, didn't test locally.

@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Oct 15, 2020
@stratoula stratoula marked this pull request as ready for review October 15, 2020 14:20
@stratoula stratoula requested a review from a team October 15, 2020 14:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
timelion 91 92 +1

async chunks size

id before after diff
timelion 393.0KB 393.1KB +90.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍 , tested in Firefox, Chrome, Safari. works

@stratoula
Copy link
Contributor Author

Thank you @kertal 🚀

@stratoula stratoula merged commit 98dc31d into elastic:master Oct 19, 2020
stratoula added a commit to stratoula/kibana that referenced this pull request Oct 19, 2020
* [Timelion] Move the local menu to the header

* nice improvement

* remove console msg

* cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula added a commit that referenced this pull request Oct 19, 2020
* [Timelion] Move the local menu to the header

* nice improvement

* remove console msg

* cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Timelion Timelion app and visualization release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Timelion] Move the local menu to the header
5 participants