[APM] Fix service map highlighted edge on node select #80791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions to correctly reset all edges in the map
ogupte
added
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
|
@ogupte if I hover over another node should the focused one lose the highlight? The image below has
|
sorenlouv
reviewed
Oct 16, 2020
| @@ -133,7 +133,7 @@ export function useCytoscapeEventHandlers({ | |||
| }; | |||
| const selectHandler: cytoscape.EventHandler = (event) => { | |||
| trackApmEvent({ metric: 'service_map_node_select' }); | |||
| resetConnectedEdgeStyle(event.target); | |||
| resetConnectedEdgeStyle(event.cy, event.target); | |||
There was a problem hiding this comment.
Shouldn't typescript have caught this?
There was a problem hiding this comment.
It didn't catch it because event.target is defined as the type any (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/cytoscape/index.d.ts#L4446), and the second param of resetConnectedEdgeStyle is optional.
sorenlouv
approved these changes
Oct 16, 2020
…hlighted-node-edges
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
@cauemarcondes this should behave like 7.9: the focused node connections don't go away from hovering on other nodes. They are only reset when other node is selected. |
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Oct 19, 2020
* Closes elastic#80633 by passing a reference to the core cytoscape options to correctly reset all edges in the map * removed commented out debugger statement
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Oct 19, 2020
* Closes elastic#80633 by passing a reference to the core cytoscape options to correctly reset all edges in the map * removed commented out debugger statement
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 20, 2020
…lout-for-warm-and-cold-tier * 'master' of github.com:elastic/kibana: (126 commits) Add cumulative sum expression function (elastic#80129) [APM] Fix link to trace (elastic#80993) Provide url rewritten in onPreRouting interceptor (elastic#80810) limit renovate to npm packages Fix bug in logs UI link (elastic#80943) [Monitoring] Fix bug with setup mode appearing on pages it shouldn't (elastic#80343) [Security Solution][Detection Engine] Fixes false positives caused by empty records in threat list docs test (elastic#81080) Fixed alerts ui test timeout issue, related to the multiple server calls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. (elastic#81067) [APM] Fix service map highlighted edge on node select (elastic#80791) Fix typo in toast, slight copy adjustment. (elastic#80843) [Security Solution] reduce optimizer limits (elastic#80997) [maps] 7.10 documentation updates (elastic#79917) [Workplace Search] Fix Group Prioritization route and clean up design (elastic#80903) [Enterprise Search] Added reusable HiddenText component to Credentials (elastic#80033) Upgrade EUI to v29.5.0 (elastic#80753) [Maps] Fix layer-flash when changing style (elastic#80948) [Security Solution] [Detections] Disable edit button when user does not have actions privileges w/ rule + actions (elastic#80220) [Enterprise Search] Handle loading state on Credentials page (elastic#80035) [Monitoring] Fix cluster listing page in how it handles global state (elastic#78979) ...
ogupte
added a commit
that referenced
this pull request
Oct 20, 2020
ogupte
added a commit
that referenced
this pull request
Oct 20, 2020
* Closes #80633 by passing a reference to the core cytoscape options to correctly reset all edges in the map * removed commented out debugger statement Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80633 by passing a reference to the core cytoscape options to correctly reset all edges in the map
