Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Long service names are not being truncated #80804

Merged
merged 5 commits into from
Oct 19, 2020
Merged

[APM] Long service names are not being truncated #80804

merged 5 commits into from
Oct 19, 2020

Conversation

cauemarcondes
Copy link
Contributor

closes #80482

Screenshot 2020-10-16 at 10 44 50

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 labels Oct 16, 2020
@cauemarcondes cauemarcondes requested a review from a team as a code owner October 16, 2020 08:53
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

sorenlouv
sorenlouv approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's much easier to do this change in sass over styled-components or inline styles I'm ok with it.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 3.3MB 3.3MB +474.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit decb9dd into elastic:master Oct 19, 2020
@cauemarcondes cauemarcondes deleted the apm-service-name branch October 19, 2020 10:52
This was referenced Oct 19, 2020
Merged
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Oct 19, 2020
@cauemarcondes
[APM] Long service names are not being truncated (elastic#80804)
1ca2a41 
* truncate service names

* using styled-components

* reverting code

* fixing unit test
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Oct 19, 2020
@cauemarcondes
[APM] Long service names are not being truncated (elastic#80804)
c56ec84 
* truncate service names

* using styled-components

* reverting code

* fixing unit test
cauemarcondes added a commit that referenced this pull request Oct 19, 2020
@cauemarcondes
[APM] Long service names are not being truncated (#80804) (#80962)
c7e46ec 
* truncate service names

* using styled-components

* reverting code

* fixing unit test
cauemarcondes added a commit that referenced this pull request Oct 19, 2020
@cauemarcondes
[APM] Long service names are not being truncated (#80804) (#80961)
f0b2dd7 
* truncate service names

* using styled-components

* reverting code

* fixing unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.10.0 v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Long service names are not being truncated
4 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv