-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added defaultActionMessage
to index threshold alert UI type definition
#80936
Merged
Merged
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a012543
resolves https://github.com/elastic/kibana/issues/78148
dB2510 8a50c7f
Merge branch 'master' into master
kibanamachine c5808a0
required changes done for https://github.com/elastic/kibana/issues/78148
dB2510 5d3b8be
Merge branch 'master' of https://github.com/dB2510/kibana
dB2510 10cf1ec
Merge branch 'master' of https://github.com/elastic/kibana
dB2510 e00826b
requested changes done https://github.com/elastic/kibana/issues/78148
dB2510 86c0e5b
functional tests for index threshold default action message
pmuellr 4cc33bc
resolved type-check and jest errors
dB2510 18c0da9
Merge branch 'master' of https://github.com/elastic/kibana
dB2510 7fe16cd
Merge pull request #1 from pmuellr/alerts/default-action-message-ft
dB2510 9c931be
Merge branch 'master' of https://github.com/elastic/kibana
dB2510 eb2b0c7
Merge branch 'master' of https://github.com/elastic/kibana
dB2510 5830f13
added functional UI test for defaultActionMessage
dB2510 31f50e6
Merge branch 'master' of https://github.com/elastic/kibana
dB2510 ebb3fee
added functional UI test to an existing test
dB2510 a519a6d
remove comments in x-pack/test/alerting_api_integration/spaces_only/t…
dB2510 b42992a
Merge branch 'master' of https://github.com/elastic/kibana
dB2510 a137daf
fix: i18n labels corrected to camelcase
dB2510 40a7093
Merge branch 'master' into master
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The i18n error in the CI seems to be caused by using
triggers_actions_ui
instead oftriggersActionsUI
, for the string above.That's a difference from other usages anyway, like this one:
kibana/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/expression.tsx
Line 109 in 4c81b1a