-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move painless lang support to @kbn/monaco #81010
Merged
alisonelizabeth
merged 4 commits into
elastic:master
from
alisonelizabeth:monaco-package-refactor
Oct 22, 2020
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4496ec1
move painless lang support to kbn/monaco
alisonelizabeth ac180cc
address review feedback
alisonelizabeth 2a74a21
Merge branch 'master' of github.com:elastic/kibana into monaco-packag…
alisonelizabeth 3a33ac0
fix tests - include monaco worker in build
alisonelizabeth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
export const ID = 'esql'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { ID } from './constants'; | ||
import { lexerRules } from './lexer_rules'; | ||
|
||
export const EsqlLang = { ID, lexerRules }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
export { lexerRules } from './esql'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
export const ID = 'painless'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { ID } from './constants'; | ||
import { lexerRules } from './lexer_rules'; | ||
|
||
export const PainlessLang = { ID, lexerRules }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
export { lexerRules } from './painless'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,16 +17,9 @@ | |
* under the License. | ||
*/ | ||
|
||
import { monaco } from '../../monaco'; | ||
import { monaco } from '../../monaco_imports'; | ||
|
||
export const ID = 'painless'; | ||
|
||
/** | ||
* Extends the default type for a Monarch language so we can use | ||
* attribute references (like @keywords to reference the keywords list) | ||
* in the defined tokenizer | ||
*/ | ||
interface Language extends monaco.languages.IMonarchLanguage { | ||
export interface Language extends monaco.languages.IMonarchLanguage { | ||
default: string; | ||
brackets: any; | ||
keywords: string[]; | ||
|
@@ -41,8 +34,7 @@ interface Language extends monaco.languages.IMonarchLanguage { | |
} | ||
|
||
export const lexerRules = { | ||
default: 'invalid', | ||
tokenPostfix: '', | ||
default: '', | ||
// painless does not use < >, so we define our own | ||
brackets: [ | ||
['{', '}', 'delimiter.curly'], | ||
|
@@ -136,9 +128,9 @@ export const lexerRules = { | |
}, | ||
], | ||
// whitespace | ||
[/[ \t\r\n]+/, { token: 'whitespace' }], | ||
[/[ \t\r\n]+/, '@whitespace'], | ||
// comments | ||
[/\/\*/, 'comment', '@comment'], | ||
// [/\/\*/, 'comment', '@comment'], | ||
[/\/\/.*$/, 'comment'], | ||
// brackets | ||
[/[{}()\[\]]/, '@brackets'], | ||
|
@@ -168,7 +160,6 @@ export const lexerRules = { | |
// strings single quoted | ||
[/'([^'\\]|\\.)*$/, 'string.invalid'], // string without termination | ||
[/'/, 'string', '@string_sq'], | ||
[/"""/, { token: 'punctuation.end_triple_quote', nextEmbedded: '@pop' }], | ||
], | ||
comment: [ | ||
[/[^\/*]+/, 'comment'], | ||
|
@@ -189,6 +180,3 @@ export const lexerRules = { | |
], | ||
}, | ||
} as Language; | ||
|
||
monaco.languages.register({ id: ID }); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I noticed the xjson and painless languages were getting registered twice - once here (and in |
||
monaco.languages.setMonarchTokensProvider(ID, lexerRules); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { XJsonLang } from './xjson'; | ||
import { PainlessLang } from './painless'; | ||
import { EsqlLang } from './esql'; | ||
import { monaco } from './monaco_imports'; | ||
// @ts-ignore | ||
import xJsonWorkerSrc from '!!raw-loader!../target/public/xjson.editor.worker.js'; | ||
// @ts-ignore | ||
import defaultWorkerSrc from '!!raw-loader!../target/public/default.editor.worker.js'; | ||
|
||
/** | ||
* Register languages and lexer rules | ||
*/ | ||
monaco.languages.register({ id: XJsonLang.ID }); | ||
monaco.languages.setMonarchTokensProvider(XJsonLang.ID, XJsonLang.lexerRules); | ||
monaco.languages.setLanguageConfiguration(XJsonLang.ID, XJsonLang.languageConfiguration); | ||
monaco.languages.register({ id: PainlessLang.ID }); | ||
monaco.languages.setMonarchTokensProvider(PainlessLang.ID, PainlessLang.lexerRules); | ||
monaco.languages.register({ id: EsqlLang.ID }); | ||
monaco.languages.setMonarchTokensProvider(EsqlLang.ID, EsqlLang.lexerRules); | ||
|
||
/** | ||
* Create web workers by language ID | ||
*/ | ||
const mapLanguageIdToWorker: { [key: string]: any } = { | ||
[XJsonLang.ID]: xJsonWorkerSrc, | ||
}; | ||
|
||
// @ts-ignore | ||
window.MonacoEnvironment = { | ||
getWorker: (module: string, languageId: string) => { | ||
const workerSrc = mapLanguageIdToWorker[languageId] || defaultWorkerSrc; | ||
|
||
const blob = new Blob([workerSrc], { type: 'application/javascript' }); | ||
return new Worker(URL.createObjectURL(blob)); | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you can see, there are a few minor differences between the painless lexer rules in xjson (original code) and the lexer rules in painless lab (original code). I don't see why they would/should be different, but if there is a reason, please let me know.