[KP] Fix Headers timeout issue #81140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
approved these changes
Oct 21, 2020
Comment on lines
76
to
79
| await performRequest(); | ||
| const defaultHeadersTimeout = 40_000; | ||
| await delay(defaultHeadersTimeout + oneSec); | ||
| await performRequest(); |
There was a problem hiding this comment.
There are no assertions in the test, the test is ensuring that the calls to performRequest do not fails du to the fix, right?
Merged
kobelb
approved these changes
Oct 21, 2020
| @@ -50,6 +50,8 @@ configService.atPath.mockReturnValue( | |||
| allowFromAnyIp: true, | |||
| ipAllowlist: [], | |||
| }, | |||
| keepaliveTimeout: 120_000, | |||
There was a problem hiding this comment.
TIL about https://v8.dev/features/numeric-separators. Very nice!
| }); | ||
| } | ||
|
|
||
| await performRequest(); |
There was a problem hiding this comment.
Your test code makes my original recreation look like 💩.
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Oct 22, 2020
* temp fix request headers bug. issue 73849 * add a focused test * move test to FTR * adjust types * some minors * small adjustments
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Oct 22, 2020
* temp fix request headers bug. issue 73849 * add a focused test * move test to FTR * adjust types * some minors * small adjustments
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 22, 2020
* master: (63 commits) [KP] Fix Headers timeout issue (elastic#81140) [ML] Functional tests - stabilize typing with checks service method (elastic#81338) tabify - support docs (elastic#80351) [Security Solution][Detections] Look-back time logic fix (elastic#81383) [Workplace Search] Add top-level tests for Groups (elastic#81215) [Fleet] Fix agent action observable for long polling (elastic#81376) [Maps] fix feature tooltip remains open when zoom level change hides layer (elastic#81373) skip flaky suite (elastic#78689) chore(NA): add spec-to-console and plugin-helpers as devOnly dependencies (elastic#81357) Ensure some data is returned (elastic#81375) Change dumb-init to tini (elastic#81126) [Reporting/Tech Debt] Convert PdfMaker class to TypeScript (elastic#81242) Use Storybook Controls instead of Knobs (elastic#80705) [junit] make sure that report paths are unique (elastic#81255) bump elastic/elasticsearch-js version to 7.10.0-rc1 (elastic#81288) run ssl tests on CI (elastic#81320) Fix alert defaults (elastic#81207) [ML] DF Analytics wizard: ensure user can set mml manually or select to use given estimate (elastic#81078) Add UI notifier to indicate secret fields and to remember / reenter values (elastic#80657) [Monitoring] Use async/await (elastic#81200) ...
mshustov
added a commit
that referenced
this pull request
Oct 22, 2020
mshustov
added a commit
that referenced
this pull request
Oct 22, 2020
|
This fix made it into the 7.10.0 release, updating the labels/description accordingly. |
💔 Build Failed
Failed CI StepsTest FailuresX-Pack API Integration Tests.x-pack/test/api_integration/apis/management/rollup/rollup·js.apis management rollup jobs Index patterns should return the date, numeric and keyword fields when an index pattern matches indicesStandard OutStack TraceChrome UI Functional Tests.test/functional/apps/discover/_doc_table·ts.discover app discover doc table add and remove columns should remove columns from the tableStandard OutStack TraceChrome UI Functional Tests.test/functional/apps/getting_started/_shakespeare·js.Getting Started Shakespeare should configure Terms aggregation on play_nameStandard OutStack TraceMetrics [docs]Saved Objects .kibana field count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Temporary workaround for #73849 will be released in
v7.10.0#73849 (comment) until #61587 is merged and released in v7.11.0Checklist
For maintainers