remove config.set() call to avoid race #8123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran this a couple times without a failure, so that's promising. |
| if (name === 'shortDots:enable') { | ||
| return false; | ||
| } else { | ||
| return origGet.call(this, name); |
There was a problem hiding this comment.
Since you're using arrow functions, I'm pretty sure this is going to bind origGet to the describe() context, which is the topmost non-arrow function. If binding isn't necessary, then just invoke it. If it is necessary, perhaps binding to $delegate would be more appropriate?
Several tests have been failing recently with "Error: Unexpected request: POST /api/kibana/settings/shortDots:enable, No more request expected" which seems to be caused by the field chooser tests calling `config.set('shortDots:enable', origValue)` in the test cleanup task. Rather than investigate it further I avoided the need to call `config.set()` by stubbing the `config.get()` method.
spalger
force-pushed
the
fix/configRaceInTests
branch
from
6f6c8e3
to
a1fb323
Compare
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
remove config.set() call to avoid race Former-commit-id: 401dea9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests have been failing recently with "Error: Unexpected request: POST /api/kibana/settings/shortDots:enable, No more request expected" which seems to be caused by the field chooser tests calling
config.set('shortDots:enable', origValue)in the test cleanup task. Rather than investigate it further I avoided the need to callconfig.set()by stubbing theconfig.get()method.See https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-intake/702/console