Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Reporting/Tech Debt] Convert PdfMaker class to TypeScript (#81242) #81400

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

tsullivan
Copy link
Member

Backports the following commits to 7.x:

…1242)

* convert pdf.js to TS

* more typescript

* simplify caller

* more typescript

* more typescript

* fix the code to match the expected interface

* very cool comment

* interface correction

* remove unused class method

* add unit test for PdfMaker

* file rename for typo correction

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
enterpriseSearch 644.5KB 644.6KB +27.0B

distributable file count

id before after diff
default 48415 48418 +3

page load bundle size

id before after diff
upgradeAssistant 64.7KB 64.7KB +27.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 3af0794 into elastic:7.x Oct 23, 2020
@tsullivan tsullivan deleted the backport/7.x/pr-81242 branch October 23, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants