Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix styling of EditDataProvider content #81456

Merged
merged 2 commits into from
Oct 26, 2020
Merged

[Security Solution] Fix styling of EditDataProvider content #81456

merged 2 commits into from
Oct 26, 2020

Conversation

patrykkopycinski
Copy link
Contributor

Summary

Before:
image

After:
image

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team labels Oct 22, 2020
@patrykkopycinski patrykkopycinski requested review from a team as code owners October 22, 2020 09:37
@patrykkopycinski patrykkopycinski self-assigned this Oct 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

andrew-goldstein
andrew-goldstein approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @patrykkopycinski!

Desk tested locally in:

  • Chrome 86.0.4240.111
  • FF 82.0
  • Safari 14.0

LGTM

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
securitySolution 8.1MB 8.1MB +9.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit a8d8add into elastic:master Oct 26, 2020
@patrykkopycinski patrykkopycinski deleted the fix/add-data-provider-styling branch October 26, 2020 12:56
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Oct 26, 2020
@patrykkopycinski @kibanamachine
[Security Solution] Fix styling of EditDataProvider content (elastic#…
bd2f848 
…81456)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@patrykkopycinski patrykkopycinski mentioned this pull request Oct 26, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Oct 26, 2020
@patrykkopycinski @kibanamachine
[Security Solution] Fix styling of EditDataProvider content (elastic#…
ab21606 
…81456)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@patrykkopycinski patrykkopycinski mentioned this pull request Oct 26, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 26, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/migrate-w…
7b2f0ba 
…arm-phase-to-formlib

* 'master' of github.com:elastic/kibana:
  [Trigger Actions UI] Properly unmount app (elastic#81436)
  skip flaky suite (elastic#81576)
  skip flaky suite (elastic#78373)
  [Security Solution] Fix styling of EditDataProvider content (elastic#81456)
  [Search] Error Alignment 2 (elastic#80965)
  [APM] Unskip test (elastic#81574)
  [ML] Fix partition value selection on the Single Metric Viewer (elastic#81585)
  cleaning up expression service types (elastic#80643)
  Fix suggestions dropdown for query input (elastic#80990)
  [Usage collection] Make `schema` mandatory (elastic#79999)
  [ILM] Update show/hide data tier logic on cloud (elastic#81455)
  added brace import to advanced settings (elastic#81458)
  chore(NA): add spec-to-console and plugin-helpers as devOnly dependencies
patrykkopycinski added a commit that referenced this pull request Oct 26, 2020
@patrykkopycinski
[Security Solution] Fix styling of EditDataProvider content (#81456) (#…
56d81ef 
…81611)
patrykkopycinski added a commit that referenced this pull request Oct 26, 2020
@patrykkopycinski @kibanamachine
[Security Solution] Fix styling of EditDataProvider content (#81456) (#…
71d47a4 
…81610)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @andrew-goldstein @MindyRS